Refactor CI workflow

[lmangani]

Removed trailing whitespace check and updated cppcheck suppressions.

Summary by CodeRabbit

• Chores
  • Updated CI/CD workflow configuration to streamline code quality checks and build processes.
  • Refined static analysis tool settings to focus on relevant code areas while improving build efficiency.

[coderabbitai]

📝 Walkthrough

Walkthrough

The CI workflow configuration was updated to remove a trailing whitespace check and refine cppcheck settings. Suppressions were adjusted, removing one check while adding six new ones. The mp3 directory was added to the exclusion list alongside existing exclusions.

Changes

Cohort / File(s)	Summary
CI Workflow Configuration .github/workflows/ci-build.yml	Removed trailing whitespace lint step; modified cppcheck suppressions (removed unusedFunction, added constVariablePointer, constParameterPointer, variableScope, uselessCallsSubstr, useStlAlgorithm, shiftNegativeLHS); expanded excluded paths to include mp3 directory.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops through workflows with glee,
Cppcheck rules adjusted, warnings run free,
mp3 paths excluded, linting made tight,
Trailing spaces gone—the build shines bright! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Refactor CI workflow' is vague and overly broad, describing the general action rather than the specific changes made.	Consider a more specific title that highlights the main changes, such as 'Update CI workflow: remove trailing whitespace check and adjust cppcheck suppressions' or 'Adjust cppcheck configuration and remove trailing whitespace check'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/ci-build.yml:
- Around line 70-75: The global cppcheck suppression "shiftNegativeLHS" should
be removed from the CI config to avoid hiding undefined
left-shift-of-negative-value bugs; delete the "--suppress=shiftNegativeLHS"
entry and instead add targeted inline suppressions (use comments like "//
cppcheck-suppress shiftNegativeLHS") at the specific functions or files that are
known false positives, or add per-file suppressions in the cppcheck config for
those exact sources; search for bit-manipulation or signal-processing functions
and update their source locations with the inline suppress comment so the rest
of the codebase remains checked for genuine shiftNegativeLHS issues.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3f704e49-2a3d-4ae7-a666-2c88e0c4de62

📥 Commits

Reviewing files that changed from the base of the PR and between 5865687 and 8d36a73.

📒 Files selected for processing (1)

• .github/workflows/ci-build.yml

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Consider keeping shiftNegativeLHS check enabled.

Most of these suppressions are reasonable style preferences. However, shiftNegativeLHS warns about left-shifting negative values, which is undefined behavior in C/C++. Suppressing this globally could mask real bugs in signal processing or bit manipulation code.

If specific instances are false positives, consider using inline suppressions (// cppcheck-suppress shiftNegativeLHS) at those locations rather than a global suppression.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci-build.yml around lines 70 - 75, The global cppcheck
suppression "shiftNegativeLHS" should be removed from the CI config to avoid
hiding undefined left-shift-of-negative-value bugs; delete the
"--suppress=shiftNegativeLHS" entry and instead add targeted inline suppressions
(use comments like "// cppcheck-suppress shiftNegativeLHS") at the specific
functions or files that are known false positives, or add per-file suppressions
in the cppcheck config for those exact sources; search for bit-manipulation or
signal-processing functions and update their source locations with the inline
suppress comment so the rest of the codebase remains checked for genuine
shiftNegativeLHS issues.

[lmangani]

This is up to @ServeurpersoCom

[coderabbitai]

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!