Skip to content

fix(username): change validations for username #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohamed-sameh-albaz merged 3 commits into from
Dec 15, 2025
Merged

fix(username): change validations for username #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
655498c
fix(username): change validations for username
mohamed-sameh-albaz Dec 15, 2025
01b4a70
Update src/user/dto/update-user.dto.ts
mohamed-sameh-albaz Dec 15, 2025
44faa64
Update src/user/dto/update-username.dto.ts
mohamed-sameh-albaz Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/user/dto/update-user.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ export class UpdateUserDto {
@IsString()
@MinLength(3, { message: 'Username must be at least 3 characters long' })
@MaxLength(50, { message: 'Username must be at most 50 characters long' })
@Matches(/^[a-zA-Z](?!.*[_.]{2})[a-zA-Z0-9._]*[a-zA-Z0-9]$/, {
@Matches(/^[a-zA-Z](?!.*[_.-]{2})[a-zA-Z0-9._-]*[a-zA-Z0-9]$/, {
message:
'Username must start with a letter, end with a letter or number, and can only contain letters, numbers, dots, and underscores — without consecutive dots or underscores.',
'Username must start with a letter, end with a letter or number, and can only contain letters, numbers, dots, underscores, and hyphens — without consecutive dots, underscores, or hyphens.',
})
@Trim()
@ToLowerCase()
Expand Down
4 changes: 2 additions & 2 deletions src/user/dto/update-username.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ export class UpdateUsernameDto {
@IsNotEmpty({ message: 'Username is required' })
@MinLength(3, { message: 'Username must be at least 3 characters long' })
@MaxLength(50, { message: 'Username must be at most 50 characters long' })
@Matches(/^[a-zA-Z](?!.*[_.]{2})[a-zA-Z0-9._]+$/, {
@Matches(/^[a-zA-Z](?!.*[_.-]{2})[a-zA-Z0-9._-]+$/, {
message:
'Username must start with a letter and can only contain letters, numbers, dots, and underscores — without consecutive dots or underscores.',
'Username must start with a letter and can only contain letters, numbers, dots, underscores, and hyphens — without consecutive dots, underscores, or hyphens.',
})
@ApiProperty({
description: 'The new username for the user',
Expand Down