fix(username): change validations for username#185
Merged
mohamed-sameh-albaz merged 3 commits intodevfrom Dec 15, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates username validation rules to allow hyphens in usernames and prevent consecutive special characters (including hyphens). The regular expressions in the @Matches decorators are modified to include hyphens in both the allowed character set and the consecutive character restriction.
Key changes:
- Updated regex patterns in two DTO files to support hyphens as valid username characters
- Extended consecutive character validation to include hyphens alongside dots and underscores
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/user/dto/update-username.dto.ts | Updated validation regex to allow hyphens and prevent consecutive special characters including hyphens |
| src/user/dto/update-user.dto.ts | Updated validation regex to allow hyphens and prevent consecutive special characters including hyphens |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.