-
Notifications
You must be signed in to change notification settings - Fork 0
ACHOO-119, ACHOO-109: Update dependencies, cache results for 6 hours #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8f18659
ACHOO-109: Update dependencies
jbickar a645b50
ACHOO-109: Cache results for 6 hours
jbickar 9f73eee
fixup! WIP
jbickar 7299d76
fixup! WIP
jbickar 40dec6a
fixup! WIP
jbickar b187d7d
Update lib/acquia-api.ts
jbickar 07d9f95
fixup! WIP
jbickar 7aa82c4
fixup! WIP
jbickar 152b5f7
fixup! WIP
jbickar 22c55ba
fixup! WIP
jbickar 14411b3
fixup! WIP
jbickar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The global cache object will persist data across all instances and requests. In a server environment, this could lead to memory leaks and unexpected data sharing between users. Consider implementing per-instance caching or using a proper cache library with memory management.