Skip to content

ACHOO-119, ACHOO-109: Update dependencies, cache results for 6 hours#6

Merged
jbickar merged 11 commits into2.xfrom
ACHOO-109
Sep 8, 2025
Merged

ACHOO-119, ACHOO-109: Update dependencies, cache results for 6 hours#6
jbickar merged 11 commits into2.xfrom
ACHOO-109

Conversation

@jbickar
Copy link
Contributor

@jbickar jbickar commented Sep 4, 2025

READY FOR REVIEW

Summary

  • Update dependencies
  • Cache results for 6 hours

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? Also see Severity Assessment.
  • E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to...
  3. Verify...

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@jbickar jbickar requested a review from Copilot September 4, 2025 20:25
@vercel
Copy link

vercel bot commented Sep 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
churro Ready Ready Preview Comment Sep 8, 2025 11:42pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates project dependencies to newer versions and implements a 6-hour caching mechanism for API responses to improve performance and reduce redundant API calls.

  • Updates multiple dependencies including Next.js, React, axios, and development tools
  • Adds caching infrastructure with a 6-hour expiration for API data
  • Implements cache checking for both application data and paginated data fetching

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
package.json Updates dependencies to newer versions and adds new CSS tooling packages
lib/acquia-api.ts Implements caching infrastructure with 6-hour TTL for API responses

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

timestamp: number; // The time the data was cached
}

const cache: Record<string, CacheEntry<any>> = {};
Copy link

Copilot AI Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The global cache object will persist data across all instances and requests. In a server environment, this could lead to memory leaks and unexpected data sharing between users. Consider implementing per-instance caching or using a proper cache library with memory management.

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jbickar jbickar merged commit 422fcd7 into 2.x Sep 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant