Skip to content

Conversation

@alexhbnr
Copy link
Collaborator

This PR enables

  • the download of the complete dates table using amdirt download
  • the filtering of the dates table for a subset of samples using amdirt convert

Additionally, it fixes the #175 issue by including the output folder in the filename.

@alexhbnr alexhbnr requested review from aidaanva and jfy133 October 23, 2025 12:14
@click.option(
"--dates",
is_flag=True,
help="Generate AncientMetagenomeDir dates table of all samples in input table"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention its single genomes only currently?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aida plans to add the dates for ancientmetagenome-hostassociated in the next hackathon. I wrote the function so that it will ignore this option when there is no dates table available for the category and instead returns an error message with an explanation.
I think this should be sufficient.

@jfy133
Copy link
Member

jfy133 commented Oct 23, 2025

Note not tested but looks simple enough

@alexhbnr alexhbnr merged commit d7c1ece into master Oct 26, 2025
6 checks passed
@alexhbnr alexhbnr deleted the dates_convert branch October 26, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants