Skip to content

Cleanup mesh intersection#281

Merged
jacobmerson merged 90 commits intoSCOREC:developfrom
jacobmerson:cleanup-mesh-intersection
Mar 15, 2026
Merged

Cleanup mesh intersection#281
jacobmerson merged 90 commits intoSCOREC:developfrom
jacobmerson:cleanup-mesh-intersection

Conversation

@jacobmerson
Copy link
Collaborator

This PR is an extension of #209. I refactored Abhiyan's code to get it closer to a state that we can merge.

@abhiyan123 if you would rather merge this and work off of your PR. I'm fine with that, I just want to get the first pass at mesh_intersections in quickly.

@jacobmerson
Copy link
Collaborator Author

jacobmerson commented Mar 9, 2026

@Sichao25 you may want to wait until @abhiyan123 indicates if he will merge these changes back to #209 or not to do the review. Once he indicates his preference I'd like to move quickly to get this finalized.

There is still a lot of cleanup that could and maybe should be done to better decouple components. My strategy was to try to at least:

  1. move all non-templated functions out of headers
  2. factor out complex code that was repeated multiple times

The error handling bits of this are still a mess, but the PR is already big enough as is. We will have to take a pass at resolving the error handling mismatch when we fix the exceptions in the rest of the library. For the petsc errors, we can utilze the macro/exception type I previously implemented for MuMFiM.

It looks like using PkgConfig for the petsc configuration broke the CI build...In my personal builds I've had better luck with the PkgConfig based targets, but we'll need to double check if there is an easy way to fix the CI for this.

@jacobmerson
Copy link
Collaborator Author

The issue with the PkgConfig based petsc installation here is that the Petsc target only seems to behave nicely when petsc is build in shared library mode.

@jacobmerson jacobmerson force-pushed the cleanup-mesh-intersection branch from 649fc41 to 195bbe9 Compare March 10, 2026 06:59
@jacobmerson jacobmerson force-pushed the cleanup-mesh-intersection branch from 195bbe9 to b42e2f0 Compare March 10, 2026 07:15
@jacobmerson jacobmerson force-pushed the cleanup-mesh-intersection branch from b42e2f0 to 5f1a1bb Compare March 10, 2026 07:26
@jacobmerson jacobmerson force-pushed the cleanup-mesh-intersection branch from 5f1a1bb to c46358b Compare March 10, 2026 23:34
@jacobmerson jacobmerson force-pushed the cleanup-mesh-intersection branch from c46358b to 3fb2430 Compare March 11, 2026 16:29
@jacobmerson jacobmerson force-pushed the cleanup-mesh-intersection branch 2 times, most recently from 82dddee to bf6321c Compare March 12, 2026 07:40
@jacobmerson jacobmerson force-pushed the cleanup-mesh-intersection branch from a3cc6ef to b21ec6c Compare March 12, 2026 18:38
@jacobmerson
Copy link
Collaborator Author

@abhiyan123 all but the one test is running on GPU. We just need to debug that and we should be able to merge.

@jacobmerson jacobmerson merged commit 0894bff into SCOREC:develop Mar 15, 2026
6 checks passed
@jacobmerson jacobmerson deleted the cleanup-mesh-intersection branch March 15, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants