Skip to content

Remove deprecated Kokkos_ENABLE_CUDA_LAMBDA #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cwsmith merged 3 commits into from
Mar 23, 2026
Merged

Remove deprecated Kokkos_ENABLE_CUDA_LAMBDA #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59cf4cd
remove CUDA_LAMBDA from cmake
Sichao25 Mar 23, 2026
b2b9c47
remove cuda_lambda from self hosted ci
Sichao25 Mar 23, 2026
9ef7e56
make Kokkos cuda lambda check conditional
Sichao25 Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/pr_comment_trigger_self_hosted.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ jobs:
-DKokkos_ENABLE_SERIAL=ON \
-DKokkos_ENABLE_OPENMP=off \
-DKokkos_ENABLE_CUDA=on \
-DKokkos_ENABLE_CUDA_LAMBDA=on \
-DKokkos_ENABLE_DEBUG=off \
-DCMAKE_INSTALL_PREFIX=$kkbdir/install
cmake --build $kkbdir --target install -j 4
Expand Down
8 changes: 5 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,11 @@ if(Omega_h_USE_Kokkos)
if ("SYCL" IN_LIST Kokkos_DEVICES)
bob_option(Omega_h_USE_SYCL "Whether to use SYCL" "ON")
endif()
if (Kokkos_ENABLE_CUDA AND (NOT "CUDA_LAMBDA" IN_LIST Kokkos_OPTIONS))
Copy link

@cwsmith cwsmith Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a version check to keep this conditional for older versions of Kokkos (at least while we are still supporting them).

Copy link
Author

@Sichao25 Sichao25 Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. I can keep this conditional for Kokkos <4.1.

message(FATAL_ERROR
"Please reconfigure Kokkos with -DKokkos_ENABLE_Cuda_Lambda:BOOL=ON")
if (Kokkos_VERSION VERSION_LESS 4.1)
if (Kokkos_ENABLE_CUDA AND (NOT "CUDA_LAMBDA" IN_LIST Kokkos_OPTIONS))
message(FATAL_ERROR
"Please reconfigure Kokkos with -DKokkos_ENABLE_Cuda_Lambda:BOOL=ON")
endif()
endif()
endif()

Expand Down
Loading