Remove deprecated Kokkos_ENABLE_CUDA_LAMBDA#211
Merged
cwsmith merged 3 commits intoSCOREC:masterfrom Mar 23, 2026
Merged
Conversation
cwsmith
reviewed
Mar 23, 2026
cwsmith
left a comment
cwsmith
left a comment
There was a problem hiding this comment.
Thank you. I left one comment below.
| if ("SYCL" IN_LIST Kokkos_DEVICES) | ||
| bob_option(Omega_h_USE_SYCL "Whether to use SYCL" "ON") | ||
| endif() | ||
| if (Kokkos_ENABLE_CUDA AND (NOT "CUDA_LAMBDA" IN_LIST Kokkos_OPTIONS)) |
There was a problem hiding this comment.
I think we should add a version check to keep this conditional for older versions of Kokkos (at least while we are still supporting them).
Author
There was a problem hiding this comment.
That's a good idea. I can keep this conditional for Kokkos <4.1.
cwsmith
approved these changes
Mar 23, 2026
Author
|
@cwsmith Would you mind running the self hosted test? |
|
/runtests |
|
Test Results:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kokkos_ENABLE_CUDA_LAMBDAis deprecated since Kokkos 4.1 and has been fully removed. As the oldest Kokkos version currently under maintenance is 4.3, this option should be removed from omega_h.