Skip to content

Conversation

@lynnt20
Copy link
Contributor

@lynnt20 lynnt20 commented Oct 27, 2025

Description

Identical to #596.

When the input artroot file(s) have 0 art events, subrun-level information (such as POT) is not properly saved in rec.hdr.* branches since they are only filled during call to art event. In order to fully persist the POT information, the POT histogram TotalPOT needs to be saved even if there are no art events in the file. Also documented in docb44065.

Note: recTree still seems to be created in the output caf files, but the genie tree is not.

(Edited to add description of additional feature):
To fully persist the number of generated events per file, a new histogram TotalGenEvents is created and saved. The input to this histogram is filled inside beginRun() if and only if a new file has been opened.

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • [N/A] Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • [N/A] Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • [N/A] Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@lynnt20 lynnt20 self-assigned this Oct 27, 2025
@lynnt20 lynnt20 added the bugfix Addresses one or more bugs label Oct 27, 2025
@lynnt20 lynnt20 mentioned this pull request Oct 27, 2025
3 tasks
@linyan-w linyan-w moved this to Expected for validation II in SBND 2025 Fall Production Oct 27, 2025
@linyan-w linyan-w moved this from Expected for validation II to Reviewer Approved in SBND 2025 Fall Production Nov 3, 2025
@kjplows kjplows moved this to Partially reviewed in SBN software development Nov 3, 2025
- add check for opening a new file
- access the run process history to get the number of generated events
- add new histogram to save ngenevt, paralleling fTotalPOT
Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #596.

@kjplows
Copy link
Contributor

kjplows commented Nov 4, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_11_01

@kjplows kjplows moved this from Partially reviewed to Testing in SBN software development Nov 4, 2025
@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Nov 4, 2025
@kjplows kjplows merged commit bd76936 into develop Nov 5, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Nov 5, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Nov 5, 2025
@linyan-w linyan-w moved this from Reviewer Approved to In tagged release in SBND 2025 Fall Production Nov 10, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Addresses one or more bugs

Projects

Status: Done
Status: In tagged release

Development

Successfully merging this pull request may close these issues.

6 participants