CAF POT Histogram (SBN 2025A) #596
Conversation
- add check for opening a new file - access the run process history to get the number of generated events - add new histogram to save ngenevt, paralleling fTotalPOT
…and Events variables
PetrilloAtWork
left a comment
PetrilloAtWork
left a comment
There was a problem hiding this comment.
It looks ok, although I don't understand the choice of histograms (a choice that was made before this PR and doesn't affect its approval).
|
|
||
| TH1* hPOT = new TH1D("TotalPOT", "TotalPOT;; POT", 1, 0, 1); | ||
| TH1* hEvents = new TH1D("TotalEvents", "TotalEvents;; Events", 1, 0, 1); | ||
| TH1* hGen = new TH1D("TotalGenEvents", "TotalGenEvents;; Events", 1, 0, 1); |
There was a problem hiding this comment.
I am actually confused by this feature.
Why is this an histogram? it looks it's just a number.
|
trigger build ci_ref=v10_06_02 LArSoft/larsoft@LARSOFT_SUITE_v10_06_00_02 LArSoft/larwirecell@LARSOFT_SUITE_v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbn*@release/SBN2025A SBNSoftware/sbndcode@v10_06_00_05 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
github-project-automation
bot
moved this from To merge
to Done
in SBN software development
Description
Identical to #597 (this PR is for 2025A spring production release)
When the input artroot file(s) have 0 art events, subrun-level information (such as POT) is not properly saved in
rec.hdr.*branches since they are only filled during call to art event. In order to fully persist the POT information, the POT histogramTotalPOTneeds to be saved even if there are no art events in the file. Also documented in docb44065.Note:
recTreestill seems to be created in the output caf files, but the genie tree is not.(Edited to add description of additional feature):
To fully persist the number of generated events per file, a new histogram TotalGenEvents is created and saved. The input to this histogram is filled inside beginRun() if and only if a new file has been opened.