Skip to content

Fix get_device_name memory leak by using CFRetained for device name #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simlay merged 1 commit into from
Dec 18, 2025
Merged

Fix get_device_name memory leak by using CFRetained for device name #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/audio_unit/macos_helpers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ use objc2_core_audio::{
AudioObjectSetPropertyData, AudioStreamRangedDescription,
};
use objc2_core_audio_types::{AudioBufferList, AudioStreamBasicDescription, AudioValueRange};
use objc2_core_foundation::CFString;
use objc2_core_foundation::{CFRetained, CFString};

use crate::audio_unit::audio_format::{AudioFormat, LinearPcmFlags};
use crate::audio_unit::sample_format::SampleFormat;
Expand Down Expand Up @@ -290,8 +290,9 @@ pub fn get_device_name(device_id: AudioDeviceID) -> Result<String, Error> {
NonNull::from(&mut device_name).cast(),
);
try_status_or_return!(status);

Ok((&*device_name).to_string())
let device_name = NonNull::new(device_name as *mut CFString).ok_or(Error::Unknown(0))?;
let device_name = CFRetained::from_raw(device_name);
Ok(device_name.to_string())
}
}

Expand Down