Fix get_device_name memory leak by using CFRetained for device name
#147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would've used CFRelease, but that isn't a public function. CFRetained calls CFRelease under the hood when it's dropped, so this is the next best thing. I noticed this leak when running instruments on Zed, please let me know if I missed anything.
Anthony-Eid
added a commit
to zed-industries/zed
that referenced
this pull request
Dec 17, 2025
The below memory leaks were caused by failing to release reference counted resources. I confirmed using instruments that my changes stopped the leaks from occurring. - System prompts - Screen capturing - loading font families There were also two memory leaks I found from some of our dependencies that I made PRs to fix - RustAudio/coreaudio-rs#147 - servo/core-foundation-rs#746 Release Notes: - N/A
HactarCE
pushed a commit
to zed-industries/zed
that referenced
this pull request
Dec 17, 2025
The below memory leaks were caused by failing to release reference counted resources. I confirmed using instruments that my changes stopped the leaks from occurring. - System prompts - Screen capturing - loading font families There were also two memory leaks I found from some of our dependencies that I made PRs to fix - RustAudio/coreaudio-rs#147 - servo/core-foundation-rs#746 Release Notes: - N/A
simlay
approved these changes
Dec 18, 2025
Member
simlay
left a comment
simlay
left a comment
There was a problem hiding this comment.
I swear I saw this on the cpal repo and glossed over it (as I only maintain coreaudio-rs).
Contributor
Author
|
What's the cpal repo? I'm asking to know if I should make a PR there |
Member
Oh, `cpal. It's just the most common dependent of coreaudio-rs. Looking at the call, it should be fixed when this is released which will get published when I merge #145 (but I'm gonna merge this and the tvOS PR first). |
Contributor
Author
|
Awesome! Thanks for responding to this PR so fast |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #125
I would've used CFRelease, but that isn't a public function. CFRetained calls CFRelease under the hood when it's dropped, so this is the next best thing.
I noticed this leak when running instruments on Zed. Please let me know if I missed anything.