Skip to content

Feat dungeon system#14

Merged
suti1110 merged 5 commits intodevelopfrom
feat-DungeonSystem
Apr 3, 2026
Merged

Feat dungeon system#14
suti1110 merged 5 commits intodevelopfrom
feat-DungeonSystem

Conversation

@suti1110
Copy link
Copy Markdown
Contributor

@suti1110 suti1110 commented Apr 3, 2026

Close #13

개요

전투 시스템과 겹치지 않는 선에서의 던전 시스템을 제작합니다. (던전의 상태 관리 프로그램)

TO-DO

  • Scripts/Dungeon/SO_DungeonState.cs 생성
  • DungeonState타입 생성(enum)
  • State가 바뀔 때 실행되는 이벤트를 생성합니다.

기타 사항

이 기능은 던전의 상태를 관리하며, 상태가 바뀔 때의 이벤트를 정의합니다.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a DungeonState enum and a SO_DungeonState ScriptableObject to manage dungeon progress and state transitions. The review feedback suggests adding the [CreateAssetMenu] attribute for editor integration, implementing OnEnable to reset the state due to ScriptableObject persistence, and renaming the DungeonState property to CurrentState to avoid naming conflicts with the enum type.

Comment on lines +20 to +30
public DungeonState DungeonState
{
get => currentState;
set
{
if (currentState == value)
return;
currentState = value;
OnDungeonStateChanged?.Invoke(currentState);
}
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

프로퍼티 이름 DungeonState가 열거형 타입 이름인 DungeonState와 동일합니다. 이는 C#에서 허용되지만, 코드 가독성을 높이고 혼동을 방지하기 위해 CurrentState와 같이 역할을 명확히 나타내는 이름으로 변경하는 것을 권장합니다.

    public DungeonState CurrentState
    {
        get => currentState;
        set
        {
            if (currentState == value)
                return;
            currentState = value;
            OnDungeonStateChanged?.Invoke(currentState);
        }
    }

Copy link
Copy Markdown

@movingfrog movingfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 했습니다

@wkdrudgnsdla
Copy link
Copy Markdown

확인했습니다.

@wkdrudgnsdla wkdrudgnsdla requested a review from movingfrog April 3, 2026 05:35
Copy link
Copy Markdown
Contributor

@leesiuuuu leesiuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다

@suti1110 suti1110 merged commit 459a3c4 into develop Apr 3, 2026
9 checks passed
@suti1110 suti1110 deleted the feat-DungeonSystem branch April 3, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants