Skip to content

fix: ParameterBuilder shouldn't append itself to the command #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nihlus merged 2 commits into from
Aug 11, 2025
Merged

fix: ParameterBuilder shouldn't append itself to the command #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a893ea
fix: Don't ammend self to parent's collection.
VelvetToroyashi Aug 11, 2025
3727310
fix(tests): Update tests according to new API behavior
VelvetToroyashi Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Remora.Commands/Builders/CommandParameterBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,8 @@ public CommandParameterBuilder(CommandBuilder builder, Type type)
{
_name = string.Empty;
_builder = builder;
_attributes = new();
_conditions = new();
builder.Parameters.Add(this);

_attributes = [];
_conditions = [];
_parameterType = type;
}

Expand Down
28 changes: 14 additions & 14 deletions Tests/Remora.Commands.Tests/Builders/CommandBuilderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,11 @@ public void CanBuildParameterizedCommand()
var commandBuilder = new CommandBuilder()
.WithName("test")
.WithInvocation((_, _, _) => default)
.WithDescription("A test command.");

_ = new CommandParameterBuilder(commandBuilder, typeof(string))
.WithName("test")
.WithDescription("A test parameter.");
.WithDescription("A test command.")
.AddParameter(typeof(string))
.WithName("test")
.WithDescription("A test parameter.")
.Finish();

var command = commandBuilder.Build(rootNode);

Expand All @@ -90,15 +90,15 @@ public void CanBuildParameterizedCommandWithMultipleParameters()
var commandBuilder = new CommandBuilder()
.WithName("test")
.WithInvocation((_, _, _) => default)
.WithDescription("A test command.");

_ = new CommandParameterBuilder(commandBuilder, typeof(string))
.WithName("test")
.WithDescription("A test parameter.");

_ = new CommandParameterBuilder(commandBuilder, typeof(int))
.WithName("test2")
.WithDescription("A second test parameter.");
.WithDescription("A test command.")
.AddParameter(typeof(string))
.WithName("test")
.WithDescription("A test parameter.")
.Finish()
.AddParameter(typeof(int))
.WithName("test2")
.WithDescription("A second test parameter.")
.Finish();

var command = commandBuilder.Build(rootNode);

Expand Down
Loading