fix: ParameterBuilder shouldn't append itself to the command #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter list remains internal (visible) for purposes of allowing CommandShape to access its list. This should *probably* be publicly exposed as `IReadOnlyList` as per proper API standards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter list remains internal (visible) for purposes of allowing CommandShape to access its list. This should probably be publicly exposed as
IReadOnlyListas per proper API standards.This fixes an issue where using the fluent API to create commands dynamically/not based off a runtime type would have duplicated parameters due to the parameter builder attaching itself while the method also appended the builder.