BowTieBuilder Code Review #168
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finished testing the LocalNeighborhood. Moving to make the dockerfile
annaritz
requested changes
Jul 9, 2024
Contributor
annaritz
left a comment
annaritz
left a comment
There was a problem hiding this comment.
Some minor comments about BTB; also please remove the local-neighborhood code. Thanks!
test/parse-outputs/expected/local_neighborhood-pathway-expected.txt
Outdated
Show resolved
Hide resolved
annaritz
reviewed
Jul 9, 2024
gabeah
commented
Jul 11, 2024
spras/btb.py
Outdated
| edges = data.get_interactome() | ||
|
|
||
| # Format into directed graph | ||
| edges.convert_undirected_to_directed() |
Contributor
Author
There was a problem hiding this comment.
change to edges = convert_undirected_to_directed(edges)
Contributor
Author
|
Merge conflict fixed! It should be all ready to be merged into spras as a whole! |
tristan-f-r
requested changes
May 23, 2025
Collaborator
tristan-f-r
left a comment
tristan-f-r
left a comment
There was a problem hiding this comment.
[these should be changed before merging]
Collaborator
There was a problem hiding this comment.
We want all of the local neighborhood files back.
| FROM python:3.8-bullseye | ||
|
|
||
| WORKDIR /btb | ||
| RUN wget https://raw.githubusercontent.com/Reed-CompBio/BowTieBuilder-Algorithm/main/btb.py |
Collaborator
There was a problem hiding this comment.
Suggested change
| RUN wget https://raw.githubusercontent.com/Reed-CompBio/BowTieBuilder-Algorithm/main/btb.py | |
| RUN wget https://raw.githubusercontent.com/Reed-CompBio/BowTieBuilder-Algorithm/dd8519cd8a8397c0e0724106f498b6002d3f7be2/btb.py |
Merged
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.