chore: update to @patternfly/elements rc#725
Conversation
🦋 Changeset detectedLatest commit: 650fb37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
this is probably blocked on jspm rebuilding our package. i already reached out. |
481b946 to
8d7eaa7
Compare
|
this should perhaps wait on patternfly/patternfly-elements#2343 to avoid churn |
|
Should we bump to node 18 to match PFE with this? |
indubitably |
|
|
There was a problem hiding this comment.
Get an error running npm start
git pull
git clean -fdx
nvm use
npm ci
npm run start
Results in:
⬆️ [start] Service started
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './dev-server.js' is not defined by "exports" in /Users/xxx/Sites/_rhds/red-hat-design-system/node_modules/@patternfly/pfe-tools/package.json imported from /Users/xxx/Sites/_rhds/red-hat-design-system/web-dev-server.config.js
at new NodeError (node:internal/errors:393:5)
at throwExportsNotFound (node:internal/modules/esm/resolve:358:9)
at packageExportsResolve (node:internal/modules/esm/resolve:668:3)
at packageResolve (node:internal/modules/esm/resolve:843:14)
at moduleResolve (node:internal/modules/esm/resolve:909:20)
at defaultResolve (node:internal/modules/esm/resolve:1124:11)
at nextResolve (node:internal/modules/esm/loader:163:28)
at ESMLoader.resolve (node:internal/modules/esm/loader:841:30)
at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18)
at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:76:40) {
code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}
❌ [start] Service exited unexpectedly
⬇️ [watch:docs] Service stopped
⬇️ [watch:compile] Service stopped
|
yeah i got those too |
Sounds good, was going down the rabbit hole, might be some missing exports in After adding: |
|
This remains blocked by patternfly/patternfly-elements#2342 |
|
wipes brow ok that's it. with the exception of the global footer playground on the footer page, which we'll do in a fast follow, this should cover it. I'mm not happy with the level of complexity in importMap.cjs, but we've been there before, and I have a few ideas for fixing it (custom providers, injectHTML, a vendor bundle) |
|
Took a look at the latest on the branch and this is looking great! I agree that the importMap and some of the regex / object.assign magic is a little much but can be improved on later. I did notice a few smaller things that can be fast follows,
PR looks good to me 👍 |
Fixed
Fixed
???
|
|
I believe 4407ef9 solves the problem of wireit running the 11ty build when tsc artifacts are missing confirm fix by running this repro in Then ctrl-c |
brianferry
left a comment
There was a problem hiding this comment.
Update looks good, thank you for all the work you've done on this @bennypowers!
What I did
@patternfly/elementsimportMap.cjsgenerator for 11ty 🤞 hopefully this is the one.Testing Instructions
git clean -dfx && npm ci && npm startshould run both the wds dev server and the 11ty dev server successfully. warning: this git clean is a destructive operationCheck all these DP demos:
Notes to Reviewers