Conversation
🦋 Changeset detectedLatest commit: 9593006 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
4747746 does two things:
At the moment I'm leaning towards keeping step 2, even if we implement FACE in pf-button, because the styles are so much cleaner and simpler. It's still 'downstream' from pfe on account of helpers and controllers, and we may upstream the face stuff into controllers and whatnot, but consider the difference between rh-button.css and BaseButton.scss. |
|
NB: there are some build issues here around class inheritance. probably will be resolved by #725 |
|
@marionnegp @nikkimk ok hopefully that should do it 🤞 |
nikkimk
left a comment
There was a problem hiding this comment.
Lexicon Grifting Technical Mumbles
|
@marionnegp yours is the last blocking review... At your leisure |
marionnegp
left a comment
There was a problem hiding this comment.
A couple changes, but everything else looks good!

What I did
based on BaseButton from pfeCloses #370
Testing Instructions
npm startAnd check the DP demos:
Notes to Reviewers