Skip to content

feat(button): add <rh-button>#550

Merged
bennypowers merged 49 commits intomainfrom
feat/button
Feb 15, 2023
Merged

feat(button): add <rh-button>#550
bennypowers merged 49 commits intomainfrom
feat/button

Conversation

@bennypowers
Copy link
Member

@bennypowers bennypowers commented Sep 29, 2022

What I did

  1. Add rh-button based on BaseButton from pfe
  2. Uses the new ElementInternals API to remove need for slotted button

Closes #370

Testing Instructions

  1. npm start

And check the DP demos:

  1. Main demo
  2. Color context demo
  3. Form control demo

Notes to Reviewers

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022

🦋 Changeset detected

Latest commit: 9593006

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rhds/elements Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 29, 2022

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit 9593006
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/63ed0daada4cfd000838f605
😎 Deploy Preview https://deploy-preview-550--red-hat-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bennypowers bennypowers changed the title feat(button): initial commit feat(button): add <rh-button> Oct 2, 2022
@bennypowers
Copy link
Member Author

4747746 does two things:

  1. Initial draft of FACE for button
  2. Extend from LitElement

At the moment I'm leaning towards keeping step 2, even if we implement FACE in pf-button, because the styles are so much cleaner and simpler. It's still 'downstream' from pfe on account of helpers and controllers, and we may upstream the face stuff into controllers and whatnot, but consider the difference between rh-button.css and BaseButton.scss.

@bennypowers bennypowers added for dev Ready for development 1:1 Components with a PatternFly v4 / PatternFly Elements representation labels Oct 3, 2022
@bennypowers bennypowers self-assigned this Oct 3, 2022
@bennypowers
Copy link
Member Author

NB: there are some build issues here around class inheritance. probably will be resolved by #725

Copy link
Collaborator

@marionnegp marionnegp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dark theme's secondary, secondary danger, and tertiary have a 3px border width with focus. Should be 2px only. Not sure what in the CSS is causing this.
Screenshot 2023-02-06 at 10 30 31 AM

@bennypowers
Copy link
Member Author

bennypowers commented Feb 14, 2023

@marionnegp @nikkimk ok hopefully that should do it 🤞

  1. Main demo
  2. Color context demo
  3. Form control demo

Copy link
Contributor

@nikkimk nikkimk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lexicon Grifting Technical Mumbles

@bennypowers
Copy link
Member Author

@marionnegp yours is the last blocking review... At your leisure

Copy link
Collaborator

@marionnegp marionnegp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple changes, but everything else looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1:1 Components with a PatternFly v4 / PatternFly Elements representation for dev Ready for development

Projects

Status: Done ☑️

Development

Successfully merging this pull request may close these issues.

[feat]: <rh-button> ready to migrate

5 participants