Skip to content

Check only major ROCm version on load#467

Merged
ipanfilo merged 1 commit intodevfrom
ipanfilo/relax_rocm_version_check
Mar 3, 2026
Merged

Check only major ROCm version on load#467
ipanfilo merged 1 commit intodevfrom
ipanfilo/relax_rocm_version_check

Conversation

@ipanfilo
Copy link
Collaborator

@ipanfilo ipanfilo commented Mar 2, 2026

Description

Check only fpr major ROCm version on TE load because minor versions should be compatible

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ipanfilo ipanfilo marked this pull request as ready for review March 2, 2026 17:30
@ipanfilo ipanfilo requested a review from VeeraRajasekhar March 2, 2026 17:31
@ipanfilo ipanfilo mentioned this pull request Mar 3, 2026
3 tasks
@ipanfilo ipanfilo merged commit f21c69e into dev Mar 3, 2026
2 checks passed
@ipanfilo ipanfilo deleted the ipanfilo/relax_rocm_version_check branch March 3, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants