Conversation
…TCH environment variable
jiagaoxiang
requested review from
ipanfilo,
wangye805 and
wenchenvincent
as code owners
Mention NVTE_ALLOW_ROCM_MISMATCH=1 directly in the mismatch assertion message so users can self-serve when runtime/build ROCm versions differ. Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
This PR makes the ROCm runtime/build version validation at import time configurable, keeping strict mismatch rejection by default while allowing an explicit opt-out via NVTE_ALLOW_ROCM_MISMATCH=1.
Changes:
- Add
NVTE_ALLOW_ROCM_MISMATCHenvironment flag to bypass ROCm version mismatch validation at import time. - Improve the mismatch error message to include bypass instructions and risk disclaimer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Emit a warning whenever NVTE_ALLOW_ROCM_MISMATCH is set and include whether a mismatch was detected plus runtime/build versions. Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Emit the ROCm mismatch warning only when NVTE_ALLOW_ROCM_MISMATCH is enabled and a runtime/build mismatch is detected, avoiding noisy logs when versions already match. Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jiagaoxiang
force-pushed
the
users/douglas/te-version-mismatch-bypass
branch
from
61a57cd to
e117c9d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Close in favor of #467 |
Summary
NVTE_ALLOW_ROCM_MISMATCH=1for environments that accept mismatch risk.Test plan
NVTE_ALLOW_ROCM_MISMATCH=1and verify import succeeds despite mismatch.Made with Cursor