Skip to content

boards: add openlabs-kw41z-mini-256kib #13524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benpicco merged 1 commit into from
Mar 11, 2020
Merged

boards: add openlabs-kw41z-mini-256kib #13524

benpicco merged 1 commit into from
Mar 11, 2020

Conversation

@benpicco
Copy link
Contributor

@benpicco benpicco commented Mar 1, 2020 •
edited
Loading

Contribution description

Add the 256k version of the openlabs-kw41z-mini.
They are identical to the openlabs-kw41z-mini except that it uses the mkw41z256vht4 instead of the mkw41z512vht4.

@benemorius says these were only sent out by mistake, but it's rather trivial to support them too and I dislike the idea of not using otherwise perfectly good hardware 😉

I also wanted to try how easy it is to support multiple boards that only differ in CPU.

We took a more elaborate approach with the different blackpill/bluepill versions which also only differ in flash size, but it turns out just providing the basic Makefiles is enough.

Testing procedure

Flash one of the 256k boards with this.

Issues/PRs references

needs #13522

@benpicco benpicco added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: boards Area: Board ports labels Mar 1, 2020
@benpicco benpicco force-pushed the openlabs-kw41z-mini-256kib branch from 9a0d638 to 625abe4 Compare March 1, 2020 23:45
@benpicco benpicco mentioned this pull request Mar 1, 2020
Merged
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 1, 2020
@benemorius
Copy link
Member

benemorius commented Mar 2, 2020 •
edited
Loading

Oh, this is brilliant! I didn't know it could be done so efficiently. Thanks for that!

I forget whether I had resolved the deal with riotboot yet but I'll investigate.

@benpicco benpicco force-pushed the openlabs-kw41z-mini-256kib branch from 625abe4 to 41df2fc Compare March 2, 2020 05:40
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 3, 2020
@benpicco benpicco force-pushed the openlabs-kw41z-mini-256kib branch from 41df2fc to 3c26ed2 Compare March 3, 2020 10:04
@benpicco benpicco requested a review from miri64 as a code owner March 3, 2020 10:04
@benpicco benpicco requested a review from leandrolanzieri March 4, 2020 15:41
@leandrolanzieri
Copy link
Contributor

leandrolanzieri commented Mar 5, 2020

I'm checking the openlabs board that I have here to see if it is a 256 or a 512. With JLink I get from the SIM_SDID register the value 0x41571004. From that I can see that it has only 64Kb (following the reference manual p.270). According to the datasheet the only MKW41Z device with that amount of RAM is the MKW41Z256VHT4.

@benpicco @benemorius is this correct? is there a simple way to check which version I have?

@benpicco
Copy link
Contributor Author

benpicco commented Mar 5, 2020

@leandrolanzieri you can check the print on the chip

#10846 (comment)

@leandrolanzieri
Copy link
Contributor

leandrolanzieri commented Mar 5, 2020

@leandrolanzieri you can check the print on the chip

#10846 (comment)

Ok so it says M41W 8VT4 1N16S CTDFMD

@benpicco benpicco force-pushed the openlabs-kw41z-mini-256kib branch from 3c26ed2 to a0416eb Compare March 5, 2020 22:40
leandrolanzieri
leandrolanzieri reviewed Mar 11, 2020
View reviewed changes
leandrolanzieri
leandrolanzieri approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, and work as expected. ACK.

@benpicco please squash.

@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Mar 11, 2020
@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Mar 11, 2020
@benpicco
boards: add openlabs-kw41z-mini-256kib
9573b2b 
Add the 256k version of the openlabs-kw41z-mini.
They are identical to the openlabs-kw41z-mini except that it uses
the mkw41z256vht4 instead of the mkw41z512vht4.
@benpicco benpicco force-pushed the openlabs-kw41z-mini-256kib branch from d66a79f to 9573b2b Compare March 11, 2020 12:50
@miri64
Copy link
Member

miri64 commented Mar 11, 2020

Only peripherally related comment: the doc of these boards is broken in the rendered versions.

@benpicco benpicco merged commit d4e05ed into RIOT-OS:master Mar 11, 2020
@benpicco benpicco deleted the openlabs-kw41z-mini-256kib branch March 11, 2020 14:42
@benpicco
Copy link
Contributor Author

benpicco commented Mar 11, 2020

I'll fix that in a separate PR.

@benpicco benpicco mentioned this pull request Mar 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@aabadie aabadie Awaiting requested review from aabadie

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

Assignees

No one assigned

Labels

Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2020.04

Development

Successfully merging this pull request may close these issues.

4 participants

@benpicco @benemorius @leandrolanzieri @miri64