Skip to content

cpu/kinetis: add mkw41z256vht4 to no-hwrng list #13522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leandrolanzieri merged 1 commit into from
Mar 3, 2020
Merged

cpu/kinetis: add mkw41z256vht4 to no-hwrng list #13522

leandrolanzieri merged 1 commit into from
Mar 3, 2020

Conversation

@benpicco
Copy link
Contributor

@benpicco benpicco commented Mar 1, 2020 •
edited
Loading

Contribution description

Some versions of the openlabs-kw41z-mini come with this chip instead of kw41z512, so let's also add that to the list.

Take from @benemorius' openlabs branch.

Testing procedure

Compilation with this CPU will otherwise fail as HWRNG is not implemented.

Issues/PRs references

@benpicco benpicco added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Area: cpu Area: CPU/MCU ports labels Mar 1, 2020
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 1, 2020
@benpicco benpicco requested a review from leandrolanzieri March 1, 2020 16:00
@benemorius
Copy link
Member

benemorius commented Mar 1, 2020

This is a very minor and reasonable change. I've tested it in my branch already. Indeed it's a necessary change in order to compile for a 256k board.

I have to apologize for the existence of the 256k boards in the wild. I thought I was the only one who had any of them. Sorry for the confusion and noise.

@benpicco benpicco mentioned this pull request Mar 1, 2020
Merged
@benpicco
Copy link
Contributor Author

benpicco commented Mar 1, 2020

How many of those unloved boards are there?
I think we could support them pretty easy - #13524

@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Mar 3, 2020
leandrolanzieri
leandrolanzieri approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although we don't use this model upstream yet, the change does not hurt. Plus, now there is #13524. ACK.

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Mar 3, 2020
@leandrolanzieri leandrolanzieri merged commit 63a5fd3 into RIOT-OS:master Mar 3, 2020
@benpicco benpicco deleted the kw41z256-hwrng branch March 3, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@aabadie aabadie Awaiting requested review from aabadie

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees

No one assigned

Labels

Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.04

Development

Successfully merging this pull request may close these issues.

3 participants

@benpicco @benemorius @leandrolanzieri