Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 7, 2026

  • Reset branch to dev-stable as requested
  • Add armadillo and OpenOrbitalOptimizer as git submodules in .gitmodules
  • Add installation logic for armadillo (CMake project)
  • Add installation logic for OpenOrbitalOptimizer (CMake project, depends on armadillo)
  • Update INSTALL.rst documentation with new packages
  • Update external/.gitignore to allow submodule directories
  • Initialize OpenOrbitalOptimizer submodule

Summary

This PR implements automatic installation support for OpenOrbitalOptimizer and armadillo as requested in the issue.

Users can now install these packages using:

  • ./configure -i armadillo - Installs the Armadillo C++ linear algebra library
  • ./configure -i openorbitaloptimizer - Installs OpenOrbitalOptimizer (depends on armadillo)

Both packages are CMake projects and are properly configured as git submodules.

Changes Made

  1. Added Git Submodules: Added armadillo (from GitLab) and OpenOrbitalOptimizer (from GitHub) as submodules in external/
  2. Configure Script: Added installation cases for both packages using CMake
  3. Documentation: Updated INSTALL.rst to list the new installable packages
  4. Git Configuration: Updated external/.gitignore to allow the new submodule directories

The OpenOrbitalOptimizer submodule has been initialized. The armadillo submodule is configured in .gitmodules and will be initialized when users run git submodule update --init in an environment with access to gitlab.com.

Original prompt

This section details on the original issue you should resolve

<issue_title>Installation of OpenOrbitalOptimizer</issue_title>
<issue_description>There are submodules for OpenOrbitalOptimizer and armadillo.
OpenOrbitalOptimizer depends on armadillo, and both are CMake projects.
The configure script should be modified to include the automatic installation of armadillo and OpenOrbitalOptimizer in the $QP_ROOT</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copy link
Member

@scemama scemama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the dev-stable branch

Copy link
Contributor Author

Copilot AI commented Jan 7, 2026

Use the dev-stable branch

I've reset the branch to be based on dev-stable (57295c9).

Copy link
Member

@scemama scemama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot I don't see any files changed.
Please work on the copilot/install-openorbitaloptimizer branch, starting from the dev-stable branch and try to merge it on dev-stable.

Copy link
Contributor Author

Copilot AI commented Jan 7, 2026

@copilot I don't see any files changed.
Please work on the copilot/install-openorbitaloptimizer branch, starting from the dev-stable branch and try to merge it on dev-stable.

I've now properly based the branch on dev-stable and implemented the changes. The commit 3ce7384a adds:

  • Git submodules for armadillo and OpenOrbitalOptimizer in .gitmodules
  • Installation logic in the configure script for both packages
  • Documentation updates in INSTALL.rst
  • Updated external/.gitignore to allow the submodule directories

The changes include 5 modified files with 34 additions total.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation of OpenOrbitalOptimizer

2 participants