71 allow for circuit to pauli exponential #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aerylia
reviewed
Jan 15, 2026
| (Angle::Arbitrary(rad1), Angle::Pi4Rotations(n2)) => { | ||
| *rad1 += n2 as f64 * PI / 4.0; | ||
| } | ||
| _ => panic!("Cannot add Arbitrary Angle to Pi4 rotation"), |
Contributor
There was a problem hiding this comment.
I guess you cannot say
(Angle::Pi4Rotations(n), Angle::Arbitrary(rad)) => { *self = Angle::Pi4Rotations(rad + n as f64 * PI / 4.0);}
Collaborator
Author
There was a problem hiding this comment.
Yup, I don't think you can do this.
|
|
||
| /// Composes a gadget onto a Clifford tableau if the angle is Clifford | ||
| /// Decomposes the Pauli gadget by performing naive decomposition into mapping to Z legs, CNOT walls and Z-rotations | ||
| pub fn compose_gadget(&mut self, rhs: (PauliString, Angle)) { |
Contributor
There was a problem hiding this comment.
Instead of inline panicing. You should probably return a Result<(), str> so you can catch it
| ]); | ||
|
|
||
| assert!(!pp1.commutes_with(&pp2)); | ||
| } |
Contributor
There was a problem hiding this comment.
Missing tests for pi4 type angles. if too much work, you can make it an issue
Collaborator
Author
There was a problem hiding this comment.
Sprinkled pi4 angles into existing tests
synpy/src/wrapper/qiskit.rs
Outdated
| #[cfg(test)] | ||
| mod tests { | ||
| #[test] | ||
| fn test_clifford_s() {} |
Collaborator
Author
There was a problem hiding this comment.
Stub removed in rebase
Only expose single function that actually merges to avoid exposing internal data stuctures.
Rename Angle::Angle to Angle::Arbitrary. Set to as it doesn't need a larger int.
keefehuang
force-pushed
the
71-allow-for-circuit-to-pauli-exponential
branch
from
e4288d7 to
ad35505
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for loop of qiskit -> rust -> qiskit