Skip to content

Conversation

@toniseibold
Copy link
Contributor

@toniseibold toniseibold commented Jan 7, 2026

Fischer-Tropsch efficiency is currently too high. Checking the old source (section 6.3.2.2) points to Fasihi et. al which is not naming the efficiency as stated in the report

The overall PtL efficiency of this system would be 51.5% (HHV), while 64.9% of inlet hydrogen is converted to liquid fuels in the H2tL plant.

To not break code - instead of just deleting the Fischer-Tropsch efficiency I propose to overwrite it with the inverse of the hydrogen input (at least that is what it's used for in e.g. PyPSA-Eur)

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
    not applicable
  • Data source for new technologies is clearly stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
    not applicable
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
    not applicable
  • I consent to the release of this PR's code under the GPLv3 license.

@toniseibold toniseibold requested a review from euronion January 7, 2026 13:31
Copy link
Collaborator

@euronion euronion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

  • Why not include the other inputs (electricity) in the calculation?
  • DEA also has FTF, I don't remember why we didn't take them before (maybe they weren't there). Maybe an alternative?
  • Have you checked whether the cross interaction with the electrobiofuels is correct? (see the entries that change as a byproduct of your change).
  • Please add release notes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants