Open
Conversation
dsocolobsky
force-pushed
the
dy/run-manager-automatic-run-selection
branch
3 times, most recently
from
163bc83 to
50fd4f6
Compare
dsocolobsky
commented
Jan 23, 2026
dsocolobsky
force-pushed
the
dy/run-manager-automatic-run-selection
branch
from
50fd4f6 to
308a0fa
Compare
dsocolobsky
changed the title
dsocolobsky
force-pushed
the
dy/run-manager-automatic-run-selection
branch
from
b1723b0 to
9be6a25
Compare
This reverts commit 49a6f18.
dsocolobsky
force-pushed
the
dy/run-manager-automatic-run-selection
branch
from
913b598 to
85f35e4
Compare
dsocolobsky
force-pushed
the
dy/run-manager-automatic-run-selection
branch
from
55e170e to
b126687
Compare
dsocolobsky
force-pushed
the
dy/run-manager-automatic-run-selection
branch
from
b126687 to
7e3d852
Compare
| .map_err(|e| anyhow!("Failed to parse wallet key: {}", e))? | ||
| } else { | ||
| // Assume base58 encoded private key | ||
| Keypair::from_base58_string(wallet_key) |
Contributor
There was a problem hiding this comment.
isn't this fallible? what happens if the string is not really a base58 encoded private key?
Contributor
Author
There was a problem hiding this comment.
Yeah from_base58_string has an internal unwrap() apparently
But I found an alternative approach calling two functions and we can validate first with a nicer error message, just pushed the changes.
| } | ||
|
|
||
| // Filter by join_authority if --authorizer was specified | ||
| if let Some(auth) = authorizer { |
Contributor
There was a problem hiding this comment.
what is the behavior when --authorizer is not set?
Contributor
Author
There was a problem hiding this comment.
It just shows all the runs you are allowed to join. --authorizer is a filter by runs with a certain authorizer (e.g. if we want to filter only by Nous runs).
dsocolobsky
force-pushed
the
dy/run-manager-automatic-run-selection
branch
from
323d78b to
951fdb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RUN_IDis not provided the run-manager will scan the solana RPC for those contracts owned by the Coordinator Program, list the runs and attempt to join one at random (which is not halted) (prioritizing waiting for compute runs).RUN_IDis provided then the behavior is the same as usual and it attempts to join the specified run.--authorizerparam to only show runs where the given pubkey is the authorizer