Closed
Conversation
IAvecilla
changed the title
AccountNotInitialized as fatal error
Contributor
Author
|
All this new logic is being added to #514 since it checks authorization previous to join the run and is already improving the error messages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly two improvements are introduced with this PR:
AccountNotInitializedwas confusing and we always keep retrying to join a run where the client does not have authorization. This will prevent the automatic retry and also make the error explicitcan_joincommand and thetrainwill both try to join the run as it was permissionless (using the system program as default) and fallback to the--authorizerpubkey or if not provided try to use the pubkey of the user running the command. This is just to avoid always using the systems program in case someone forgots to use theauthorizerflag