Use the namespaced class for Scribunto as the alias was removed

[physikerwelt]

From ChatGPT via @LizzAlice

Scribunto_LuaLibraryBase (the old underscore-style global class) was an alias for the namespaced class:

MediaWiki\Extension\Scribunto\Engines\LuaCommon\LibraryBase (gerrit.wikimedia.org)

In current Scribunto, the alias line class_alias( LibraryBase::class, 'Scribunto_LuaLibraryBase' ); was removed (along with the autoload entry for Scribunto_LuaLibraryBase). (gerrit.wikimedia.org)

Summary by CodeRabbit

• Refactor
  • Updated internal code architecture and library dependencies to improve maintainability and stability. These structural enhancements strengthen the technical foundation for future development while maintaining complete backward compatibility with all existing features and functionality.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The SparqlLua class base class inheritance was updated from Scribunto_LuaLibraryBase to LibraryBase, with the corresponding use import changed to MediaWiki\Extension\Scribunto\Engines\LuaCommon\LibraryBase. No method signatures or functional logic modifications were made.

Changes

Cohort / File(s)	Summary
Base class refactoring src/SparqlLua.php	Updated class inheritance from Scribunto_LuaLibraryBase to LibraryBase and revised the import statement to MediaWiki\Extension\Scribunto\Engines\LuaCommon\LibraryBase

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately describes the main change: replacing the removed alias Scribunto_LuaLibraryBase with the namespaced LibraryBase class, which is the core purpose of the changeset.

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI Agents

In @src/SparqlLua.php:
- Line 11: SparqlLua extends the namespaced LibraryBase from Scribunto but
composer.json lacks the Scribunto dependency; add "mediawiki/scribunto" with a
minimum version (e.g. >=3.1) to the composer.json "require" section, then run
composer update/install to update composer.lock so the
MediaWiki\Extension\Scribunto\Engines\LuaCommon\LibraryBase class is available
at runtime.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3770846 and 33e5d09.

📒 Files selected for processing (1)

• src/SparqlLua.php

🧰 Additional context used

🪛 GitHub Actions: CI

src/SparqlLua.php

[error] 11-11: Class "MediaWiki\Extension\Scribunto\Engines\LuaCommon\LibraryBase" not found.

🔇 Additional comments (1)

src/SparqlLua.php (1)

9-9: LGTM! Correct namespaced import.

The use statement correctly imports the namespaced LibraryBase class from Scribunto, replacing the deprecated global alias.

[malberts]

We will need to drop MW 1.39 support along with this. Which should be fine since that is EOL now anyway.