Skip to content

Require MediaWiki 1.43#25

Merged
JeroenDeDauw merged 1 commit intomasterfrom
rm-39
Jan 6, 2026
Merged

Require MediaWiki 1.43#25
JeroenDeDauw merged 1 commit intomasterfrom
rm-39

Conversation

@malberts
Copy link
Contributor

@malberts malberts commented Jan 6, 2026

For #24 (comment)

Summary by CodeRabbit

  • Chores

    • Version bumped to 2.0.0
    • Minimum MediaWiki requirement increased to 1.43 (previously 1.39)
  • Tests

    • Updated CI infrastructure to support newer MediaWiki versions and PHP 8.5 compatibility
  • Documentation

    • Updated platform compatibility information in release notes

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 6, 2026

📝 Walkthrough

Walkthrough

Configuration and versioning updates across CI workflows, documentation, and manifest files. CI matrices transitioned to newer MediaWiki branches (REL1_43 through REL1_45) and added PHP 8.5. Extension version bumped to 2.0.0-dev with minimum MediaWiki requirement raised to 1.43.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/ci.yml
Updated test matrices across all jobs (test, PHPStan, Psalm, code-style) replacing older REL1_X branches with REL1_43–REL1_45; added PHP 8.5 on master branch with experimental flag
Documentation & Release Notes
README.md
Updated tested PHP version to 8.5 and MediaWiki to 1.45; added Version 2.0.0 release notes (appears duplicated in file) documenting minimum MediaWiki bump to 1.43
Extension Manifest
extension.json
Bumped extension version to 2.0.0-dev and raised minimum MediaWiki requirement from 1.39.0 to 1.43.0

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Update CI #22: Similar CI workflow matrix updates and README version documentation changes (MediaWiki and PHP version bumps).

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating the MediaWiki minimum requirement from 1.39 to 1.43 across extension.json, README.md, and CI workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0e21ec and 26744a3.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • README.md
  • extension.json
🔇 Additional comments (6)
extension.json (2)

4-4: LGTM! Appropriate major version bump.

The version bump to 2.0.0-dev correctly follows semantic versioning for a breaking change (raising the minimum MediaWiki requirement).


17-17: No deprecated APIs detected; MediaWiki 1.43+ compatibility confirmed.

The extension uses modern MediaWiki service APIs throughout (MediaWikiServices, ServiceOptions, HttpRequestFactory) with no usage of deprecated patterns. The codebase is compatible with MediaWiki 1.43+.

README.md (2)

60-61: LGTM! Platform requirements updated correctly.

The PHP and MediaWiki version requirements are consistent with the changes in extension.json and the CI matrix.


129-132: LGTM! Release notes accurately document the breaking change.

The release notes clearly indicate the raised minimum MediaWiki version, which is the primary breaking change in this release.

.github/workflows/ci.yml (2)

118-118: LGTM! Static analysis jobs updated consistently.

All static analysis jobs (PHPStan, Psalm, code-style) have been updated to use REL1_43, ensuring that code quality checks run against the new minimum MediaWiki version.

Also applies to: 184-184, 250-250


15-29: MediaWiki branch names are all valid and the test matrix provides comprehensive coverage.

The updated CI matrix appropriately tests across supported releases: REL1_43 (LTS), REL1_44 (legacy stable), REL1_45 (current stable as of December 2025), and master (development). The experimental PHP 8.5 with master is appropriate for forward compatibility testing.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@malberts malberts requested a review from alistair3149 January 6, 2026 13:33
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
README.md (1)

75-75: Update the Composer version constraint to match the new major version.

The installation command still references ~1.0, but the extension version has been bumped to 2.0.0-dev. Users following this command will not install the correct version.

🔎 Proposed fix
-COMPOSER=composer.local.json composer require --no-update professional-wiki/sparql:~1.0
+COMPOSER=composer.local.json composer require --no-update professional-wiki/sparql:~2.0
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0e21ec and 26744a3.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • README.md
  • extension.json
🔇 Additional comments (6)
extension.json (2)

4-4: LGTM! Appropriate major version bump.

The version bump to 2.0.0-dev correctly follows semantic versioning for a breaking change (raising the minimum MediaWiki requirement).


17-17: No deprecated APIs detected; MediaWiki 1.43+ compatibility confirmed.

The extension uses modern MediaWiki service APIs throughout (MediaWikiServices, ServiceOptions, HttpRequestFactory) with no usage of deprecated patterns. The codebase is compatible with MediaWiki 1.43+.

README.md (2)

60-61: LGTM! Platform requirements updated correctly.

The PHP and MediaWiki version requirements are consistent with the changes in extension.json and the CI matrix.


129-132: LGTM! Release notes accurately document the breaking change.

The release notes clearly indicate the raised minimum MediaWiki version, which is the primary breaking change in this release.

.github/workflows/ci.yml (2)

118-118: LGTM! Static analysis jobs updated consistently.

All static analysis jobs (PHPStan, Psalm, code-style) have been updated to use REL1_43, ensuring that code quality checks run against the new minimum MediaWiki version.

Also applies to: 184-184, 250-250


15-29: MediaWiki branch names are all valid and the test matrix provides comprehensive coverage.

The updated CI matrix appropriately tests across supported releases: REL1_43 (LTS), REL1_44 (legacy stable), REL1_45 (current stable as of December 2025), and master (development). The experimental PHP 8.5 with master is appropriate for forward compatibility testing.

@JeroenDeDauw JeroenDeDauw merged commit a3827a3 into master Jan 6, 2026
16 checks passed
@JeroenDeDauw JeroenDeDauw deleted the rm-39 branch January 6, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants