Conversation
📝 WalkthroughWalkthroughConfiguration and versioning updates across CI workflows, documentation, and manifest files. CI matrices transitioned to newer MediaWiki branches (REL1_43 through REL1_45) and added PHP 8.5. Extension version bumped to 2.0.0-dev with minimum MediaWiki requirement raised to 1.43. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🔇 Additional comments (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
75-75: Update the Composer version constraint to match the new major version.The installation command still references
~1.0, but the extension version has been bumped to2.0.0-dev. Users following this command will not install the correct version.🔎 Proposed fix
-COMPOSER=composer.local.json composer require --no-update professional-wiki/sparql:~1.0 +COMPOSER=composer.local.json composer require --no-update professional-wiki/sparql:~2.0
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/ci.ymlREADME.mdextension.json
🔇 Additional comments (6)
extension.json (2)
4-4: LGTM! Appropriate major version bump.The version bump to 2.0.0-dev correctly follows semantic versioning for a breaking change (raising the minimum MediaWiki requirement).
17-17: No deprecated APIs detected; MediaWiki 1.43+ compatibility confirmed.The extension uses modern MediaWiki service APIs throughout (MediaWikiServices, ServiceOptions, HttpRequestFactory) with no usage of deprecated patterns. The codebase is compatible with MediaWiki 1.43+.
README.md (2)
60-61: LGTM! Platform requirements updated correctly.The PHP and MediaWiki version requirements are consistent with the changes in extension.json and the CI matrix.
129-132: LGTM! Release notes accurately document the breaking change.The release notes clearly indicate the raised minimum MediaWiki version, which is the primary breaking change in this release.
.github/workflows/ci.yml (2)
118-118: LGTM! Static analysis jobs updated consistently.All static analysis jobs (PHPStan, Psalm, code-style) have been updated to use REL1_43, ensuring that code quality checks run against the new minimum MediaWiki version.
Also applies to: 184-184, 250-250
15-29: MediaWiki branch names are all valid and the test matrix provides comprehensive coverage.The updated CI matrix appropriately tests across supported releases: REL1_43 (LTS), REL1_44 (legacy stable), REL1_45 (current stable as of December 2025), and master (development). The experimental PHP 8.5 with master is appropriate for forward compatibility testing.
For #24 (comment)
Summary by CodeRabbit
Chores
Tests
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.