feat: audit infrastructure - actions, resolvers, and formatters#261
Merged
paymonsattar merged 2 commits intomainfrom Apr 7, 2026
Merged
feat: audit infrastructure - actions, resolvers, and formatters#261paymonsattar merged 2 commits intomainfrom
paymonsattar merged 2 commits intomainfrom
Conversation
This was referenced Apr 1, 2026
Closed
oscargay
requested changes
Apr 2, 2026
Collaborator
oscargay
left a comment
There was a problem hiding this comment.
Looks great, this is a very readable addition that I can see being easy to add new items to. Only a few comments, the main things are:
- Some of the resolves are 1 long function and it could be nice to break them down a little more into sub functions
- Overall this adds a layer of technical overhead, when adding a new feature a developer will need to know that they have to check & potentially add to the resolvers to get the audit to work, this is fine but we need some way of making sure that this doesn't slip through the cracks in future dev work - what do you think? It could be a documentation thing!
Great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
https://pins-ds.atlassian.net/browse/HRP-296