-
Notifications
You must be signed in to change notification settings - Fork 3
adding leds to the lib, UNTESTED #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
blazecoding2009
wants to merge
3
commits into
PerfectlyInternal:2024
Choose a base branch
from
blazecoding2009:2024-leds
base: 2024
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| /* | ||
| * Package: com.orbit.frc.subsystems.leds | ||
| * Description: This package contains classes related to controlling LEDs on a robot. | ||
| */ | ||
|
|
||
| package com.orbit.frc.subsystems.leds; | ||
|
|
||
| import java.util.HashMap; | ||
|
|
||
| import edu.wpi.first.wpilibj.Spark; | ||
| import edu.wpi.first.wpilibj2.command.SubsystemBase; | ||
|
|
||
| /* | ||
| * Class: Leds | ||
| * Description: This class represents the subsystem responsible for controlling LEDs on a robot. | ||
| */ | ||
| public class Leds { | ||
| private final LedConfig config; // Configuration object for LEDs | ||
|
|
||
| private double LEDColour; // Current color of LEDs | ||
| public LEDStates LEDstate; // Current state of LEDs | ||
|
|
||
| HashMap<LEDStates, Double> LEDStatesMap = new HashMap<>(); // Map to store LED states and corresponding colors | ||
|
|
||
| /* | ||
| * Constructor: Leds | ||
| * Description: Initializes the LED subsystem with the provided configuration. | ||
| * Parameters: | ||
| * - config: Configuration object for LEDs | ||
| */ | ||
| public Leds(LedConfig config) { | ||
| this.LEDController = new Spark(config.LEDPort); // Initialize LED controller | ||
| this.LEDColour = 0.0; // Default LED color | ||
| this.LEDstate = LEDStates.ENABLED; // Default LED state | ||
| } | ||
|
|
||
| /* | ||
| * Method: addLEDState | ||
| * Description: Adds a new LED state with the specified color to the LED states map. | ||
| * Parameters: | ||
| * - state: Name of the LED state | ||
| * - colour: Color of the LED state from revdocs | ||
| */ | ||
| public void addLEDState(String state, double colour) { | ||
| LEDStatesMap.put(state, colour); // Add LED state to the map | ||
| } | ||
|
|
||
| /* | ||
| * Method: setLEDState | ||
| * Description: Sets the current LED state. | ||
| * Parameters: | ||
| * - state: Name of the LED state to set | ||
| */ | ||
| public void setLEDState(String state) { | ||
| this.LEDstate = state; // Set LED state | ||
| } | ||
|
|
||
| /* | ||
| * Method: periodic | ||
| * Description: This method is called periodically to update the LED color based on the current LED state. | ||
| */ | ||
| @Override | ||
| public void periodic() { | ||
| this.LEDColour = LEDStatesMap.get(this.LEDstate); // Get color for the current LED state | ||
| this.LEDController.set(this.LEDColour); // Set LED color | ||
| } | ||
| } | ||
12 changes: 12 additions & 0 deletions
12
src/main/java/com/orbit/frc/subsystems/leds/LedsConfig.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package main.java.com.orbit.frc.subsystems.leds; | ||
|
|
||
| import com.orbit.frc.subsystems.SubsystemConfig; | ||
|
|
||
| public class LedsConfig extends SubsystemConfig{ | ||
blazecoding2009 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| /* LED config | ||
| * | ||
| */ | ||
| public int LEDPort; | ||
| public Spark LEDController; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remember to change references to the controller when its in the config, and also check to see if it should be inited from port or just using the object passed in the config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo it should be inited from the port, makes it less confusing in config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the user wants to provide their own spark object, we should support that