adding leds to the lib, UNTESTED#1
adding leds to the lib, UNTESTED#1blazecoding2009 wants to merge 3 commits intoPerfectlyInternal:2024from
Conversation
PerfectlyInternal
left a comment
PerfectlyInternal
left a comment
There was a problem hiding this comment.
a few minor changes to keep stuff in order, overall looks like it should work
| public class Leds extends SubsystemBase { | ||
| private final LedConfig config; // Configuration object for LEDs | ||
|
|
||
| private Spark LEDController; // Spark object for controlling LEDs |
There was a problem hiding this comment.
move this to the config so the user can pass their own spark if theyd like
There was a problem hiding this comment.
confused about this, how would i do that
There was a problem hiding this comment.
take a look at other subsystems that use non-motor hardware & their configs
There was a problem hiding this comment.
all sybsystems haev motors 💀
| * - config: Configuration object for LEDs | ||
| */ | ||
| public Leds(LedConfig config) { | ||
| this.LEDController = new Spark(config.LEDPort); // Initialize LED controller |
There was a problem hiding this comment.
remember to change references to the controller when its in the config, and also check to see if it should be inited from port or just using the object passed in the config
There was a problem hiding this comment.
imo it should be inited from the port, makes it less confusing in config
There was a problem hiding this comment.
If the user wants to provide their own spark object, we should support that
2 participants
No description provided.