Fix/admin-profile-name-updatev2 #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and setters for profile fields
gomez-ashleyhermione
requested review from
andaya-gener,
barcelos-kevin,
relente-patriciajoy and
uy-angelicajoy
relente-patriciajoy
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed admin profile first/last name update not persisting.
Admin users could edit first/last names and see a success message, but changes would revert. Issue was caused by:
Backend DTO missing firstName/lastName fields
Frontend form conflicting disabled state management
Changes:
Added firstName/lastName to UpdateProfileRequest DTO with getters/setters
Updated AuthService.updateUserProfile() to persist name changes
Fixed frontend form binding by removing conflicting [disabled] attributes
Now uses getRawValue() and reflects changes immediately