Optimize permutation and Z-score calculation, added optional early st…#5
Open
FilyCode wants to merge 1 commit intoPFPrzytycki:cellwalkerfrom
Open
Optimize permutation and Z-score calculation, added optional early st…#5FilyCode wants to merge 1 commit intoPFPrzytycki:cellwalkerfrom
FilyCode wants to merge 1 commit intoPFPrzytycki:cellwalkerfrom
Conversation
…opping, performance improvment for large scale cell mapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance improvements for large-scale cell type mapping while maintaining exact numerical compatibility.
Changes
compute_zscore: Replace loops with array operations (3-5x speedup)simulate_rand0: Improved readability and ~15% performance gainmapCellTypes:enable_convergence,conv_threshold,conv_windowCompatibility
Testing
Tested on spatial scRNAseq and scATACseq datasets
Files Changed
R/CellWalkerFunctionsExtra.R: Optimized Z-score computationR/MapCellTypesFunctions.R: Added convergence checking and refactored main function