Skip to content

Cleanup unused toggleCandidate function in static/app.js #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Cleanup unused toggleCandidate function in static/app.js #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions static/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,20 +212,6 @@ createApp({

const getActiveCount = (group) => group.candidates.filter(c => c.selected).length;

const toggleCandidate = (group, idx) => {
// No-op here if using v-model, but let's keep it or remove it.
// Since we switch to v-model in the template, this function might become obsolete
// OR we can keep it if we want to programmatically toggle.
// But the previous implementation used indices.
// The template currently calls it. I will update the template to use v-model.
// So I can remove this function or just leave a placeholder.
// Actually, let's just make it toggle the boolean for the candidate at that index if needed,
// but v-model is cleaner. I'll remove it from the return object if I don't use it.
// But to be safe, I'll update it to toggle boolean.
const c = group.candidates[idx];
if (c) c.selected = !c.selected;
};

const removeGroup = (idx) => groups.value.splice(idx, 1);

const generateSchedules = async () => {
Expand Down Expand Up @@ -330,7 +316,7 @@ createApp({
currentView, loading, searchParams, searchResults,
groups, preferences, schedules, currentScheduleIdx, currentWeek,
filterText, hasSearched, filteredSearchResults,
doSearch, createGroup, getGroupName, getActiveCount, toggleCandidate, removeGroup,
doSearch, createGroup, getGroupName, getActiveCount, removeGroup,
generateSchedules, getCell, downloadImage, saveSession, newSession, toastRef,
toggleSelectAll,
showImportModal, importText, isImporting, importStatus, importParams,
Expand Down