Skip to content

Fix flaky test in Base64Test by removing dependence on field ordering #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lbh930 wants to merge 1 commit into
base: ea
Choose a base branch
from
+8 −2
Open

Fix flaky test in Base64Test by removing dependence on field ordering #1238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/test/java/net/openhft/chronicle/wire/converter/Base64Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,13 @@ public void onAnField() {
"...\n";

// Validate the wire's output against the expected output
assertEquals(expected, wire.toString());
java.util.function.Function<String, String> sort = s -> java.util.Arrays.stream(s.split("\n"))
.map(l -> l.trim().replaceAll(",$", ""))
.filter(l -> !l.isEmpty() && !l.equals("...") && !l.equals("}") && !l.equals("send: {"))
.sorted()
.collect(java.util.stream.Collectors.joining("\n"));

assertEquals(sort.apply(expected), sort.apply(wire.toString()));

// Create another YAML wire for reading the encoded data
Wire wire2 = Wire.newYamlWireOnHeap();
Expand All @@ -79,7 +85,7 @@ public void onAnField() {
assertEquals(i < 5, reader.readOne());

// Ensure the read wire's content matches the expected output
assertEquals(expected, wire2.toString());
assertEquals(sort.apply(expected), sort.apply(wire2.toString()));
}

/**
Expand Down