Fix flaky test in Base64Test by removing dependence on field ordering #1238
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbh930
force-pushed
the
fix_base64test_flakiness
branch
2 times, most recently
from
101142a to
282e10a
Compare
Author
|
This PR is updated to make changes shorter. |
lbh930
force-pushed
the
fix_base64test_flakiness
branch
from
282e10a to
ab85129
Compare
lbh930
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified
Base64Test.javato sort the serialized fields before comparing them with the expected output. This ensures that the test is deterministic and doesn't depend on the iteration order ofClass.getDeclaredFields(), which does not guarantee consistency.Motivation
NonDex detected test flakiness in
net.openhft.chronicle.wire.converter.Base64Test.onAnFieldand the cause was that the test asserted a specific order of fields in the serialized YAML string. SinceSelfDescribingMarshallableuses reflection to discover fields, the order is not guaranteed. An example of NonDex output with detected test failure is attached.nondex_output_base64test.txt