Rework and improvements

[OgelGames]

Big PR with lots of changes, testing will be needed before merging.

• Added entity mode as a fallback when a node can't be placed, and check if items spawn when dropping items. Dropping items is not reliable #9
• Added bones_fallback_mode setting to change behavior when bones can't be created. Add option to disable item drops while bones_mode=bones #8
• Added chat message when collecting another player's bones, and when trying to collect owned bones. Suggestion: Chat-message on pickup #5
• Added obituary item that is given to players on death and shows a list of items. Dropped items list #4
• When a player collects their bones, items are restored to their original inventories.
• When bones replace a node on placement, the node is restored when the bones are collected.
• Enable bones to be picked up with items inside, and add bones_pickup as a setting to disable.
• Added distinct log message when a player fully collects bones.
• Fixed waypoints not being removed when at -0.5 to 0 on any axis.
• Fixed soulbound armor being ignored. (added in minetest-mods/3d_armor@1d8509e)
• Fixed rotation of bones being reversed.

Closes #9, fixes #5, fixes #4.

[OgelGames]

@SwissalpS @Niklp09 (request reviewers isn't working)

[SwissalpS]

I love the way inv list and order is restored now.
One hickup: die with full inventory, crafting grid and armour. Then put on some armour. Now punch bones -> the piece of armour that didn't fit in the slot drops and bones vanish. Expected behaviour: bones remain in world containing extra armour.
This might be a quirk with armour inv as it didn't seem to happen with main inventory, there bones remained.

Edit: *bones vanished: they stacked onto other bones that were in main inv.

[OgelGames]

Ah, that's a 3d_armor thing, looks like I'll have to avoid calling armor:equip().

https://github.com/minetest-mods/3d_armor/blob/8f775a64f0a29afbcc63cbcd78938c17609ed187/3d_armor/api.lua#L731

[SwissalpS]

If it is easier to check first and only use armor.equip() if slot isn't already occupied.

[OgelGames]

I found a better solution: minetest-mods/3d_armor#166

[SwissalpS]

I was wondering .... if entities used detached inventories couldn't we then use the same functions for nodes and entities when it comes to formspec and item movement checks?

[Niklp09]

Just checked the fallback mode for now, looks good.
The entity layer should further reduce lost items. 👍

[SwissalpS]

have you considered making obituary flamable?