Skip to content

Conversation

@SwissalpS
Copy link
Contributor

This PR tries to bring back the inventory formspec allowing players to cherry-pick items. e.g. collector can't wrench bones because bones contain wrenched items.

Also I enjoy being able to peek into bones - curiosity.

@OgelGames OgelGames marked this pull request as draft November 5, 2025 05:55
@OgelGames
Copy link
Owner

I will look into this and #14 after merging #15

@SwissalpS
Copy link
Contributor Author

SwissalpS commented Nov 6, 2025

haven't tested much yet and haven't included entities - there are certainly some things to clean up and optimize.

Edit: Something that may cause troubles is that the armor inv can now be used for anything, so there may be a problem when punched after having messed around with inventories.

I'm considering using a scrollable area for the inventories of bones - if that works at all. The formspec becomes huge now with split inventories.

@OgelGames
Copy link
Owner

I still think bones don't need the complexity of a formspec, just for the few times someone would need to look inside them, and the sneak-punch to pickup added in #14 already fixes the wrench problem (though it still checks the size of the metadata).

And one of the reasons I removed the formspec when I redid bones, besides the reduction in complexity, was to prevent players leaving bones in the world just because they didn't want some junk items.

@SwissalpS
Copy link
Contributor Author

What about view-only formspec? That would also reduce the size as the player's inv wouldn't need to be shown.

@OgelGames
Copy link
Owner

That could work, you could even simplify it and use item images and tooltips to eliminate the need for detached inventories 🤔

@SwissalpS
Copy link
Contributor Author

yep, and could skip empty solts to save even more screen estate.

@SwissalpS
Copy link
Contributor Author

Something like c5eb604 - not as pretty as using list[...] especially the count. Needs to be right-aligned.
Using item_image_button[...] looks better than item_image[...], slightly.

@SwissalpS
Copy link
Contributor Author

I'd prefer using list[...] for nodes (without modification permissions) and above version for entities.

@OgelGames
Copy link
Owner

For the reasons I mentioned above, I have decided against re-implementing formspecs.

@OgelGames OgelGames closed this Jan 5, 2026
@OgelGames OgelGames added the wontfix This will not be worked on label Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants