MSVC: fix nan/inf issues on msvc and gcc #5511
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply clang-format formatting Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
…urrently initialized to 0.
github-actions
bot
added
vector
Member
Author
|
I've reverted in a separate commit to use the initialized value that is now used. When the original commit was made, it was initialized with nan (0.0/0.0). I wanted to show what the commit made when cherry-picking, so there would be a trace, |
Closed
echoix
added
the
conflicts/needs rebase
echoix
removed
the
conflicts/needs rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #355
I cherry-picked and manually adjusted the remaining of #355 to be updated, mergeable, and reviewable. I don't necessarily endorse or think everything is needed, but allows to close #355 for the time being. Please look if these still make sense, considering the changes done in #2681. Do they apply correctly to MSVC?