Msvc nan inf #355

rkanavath · 2020-02-18T00:06:43Z

To be merged after #354

This is not a search and replace of __MING32__ with _WIN32. There are places where __MINGW32__ is still used and all changes are tested with MSVC 2019 compiler. Although, this commit alone will not work on MSVC because there are plenty of other things to be done which are seperated into multiple PR. PR OSGeo#289 is the one that "works" on MSVC and unix as well. But that contains too many changes which shouldn't in a single PR. Even though this PR alone won't compile GRASS GIS on MSVC, it sure will not break existing compilers which I think is very important. Complete support for MSVC will be ready after 2/3 PRs OSGeo#289

static int initialized is not working for MSVC and must export this with __declspec so that it appears in a DLL correctly. This change has been tested on Ubuntu and MSVC 2019 and is working as expected.

Below is a code from filldepr.cpp which throws error on msvc compiler function has G_fatal_error() so it is 'normal' to have no return type. But MSVC complains that function's return type is elevation_type* and does not return anything. elevation_type* ext_fill_depression(AMI_STREAM<boundaryType> *boundaryStr, cclabel_type maxWatersheds) { G_fatal_error(_("Fill_depressions do not fit in memory. Not implemented yet")); }

The MSVC compiler only supports C90, it does not support C99 and variable length arrays are a feature of C99.

wenzeslaus · 2025-02-19T16:40:54Z

Was this addressed somewhere? I don't know. Please, close if you know the PR where this was fixed. Otherwise, I suggest closing this when CMake build works on Windows.

echoix

This PR starts after #354, that finishes with ceb1d12. So, there is only one real commit in this PR, f76f205.

The issues have been changed differently in #2681, using NAN and INFINITY, but there's a note that it might not work on MSVC, or at least for the versions at that time.

echoix · 2025-04-06T17:58:59Z

general/g.region/printwindow.c

+		// GCC 5.4.0 says 0./0. is -nan
+		// Clang 3.8.0 says 0./0. is nan
+		// I stick to -nan in msvc too. But this has to rechecked.
+	    sscanf("-nan", "%lf", &convergence);


In #2681, the code was changed to use NAN, but there's a note that some of them won't work for MSVC (at that time), but it was not mentioned for the NAN change.

if (G_projection() == PROJECTION_XY) convergence = NAN;

echoix · 2025-04-06T18:00:44Z

lib/btree2/kdtree.c

 	sn.uid = *skip;

-    maxdist = 1.0 / 0.0;
+    sscanf("inf", "%lf", &maxdist);


In #2681, the code was changed to use INFINITY, but there's a note that it might not for MSVC (at that time)

echoix · 2025-04-06T18:03:10Z

lib/vector/Vlib/box.c

+	double nan_val;
+	sscanf("-nan", "%lf", &nan_val);
+	Box->N = Box->S = Box->E = Box->W = Box->T = Box->B = nan_val;


In #2681, the code was changed to use NAN:

Line = Plus->Line[line]; if (Line == NULL) { /* dead */ Box->N = Box->S = Box->E = Box->W = Box->T = Box->B = NAN; return 0; }

echoix · 2025-04-06T18:04:06Z

lib/vector/Vlib/box.c

+	double nan_val;
+	sscanf("-nan", "%lf", &nan_val);
+	Box->N = Box->S = Box->E = Box->W = Box->T = Box->B = nan_val;


In #2681, the code was changed to use NAN:

if (Area == NULL) { /* dead */ Box->N = Box->S = Box->E = Box->W = Box->T = Box->B = NAN; return 0; }

echoix · 2025-04-06T18:04:48Z

lib/vector/Vlib/box.c

+	double nan_val;
+	sscanf("-nan", "%lf", &nan_val);
+	Box->N = Box->S = Box->E = Box->W = Box->T = Box->B = nan_val;


In #2681, the code was changed to use NAN:

Isle = Plus->Isle[isle]; if (Isle == NULL) { /* dead */ Box->N = Box->S = Box->E = Box->W = Box->T = Box->B = NAN; return 0; }

echoix · 2025-04-06T18:28:05Z

raster3d/r3.in.lidar/info.c

+	double nan_val;
+	sscanf("-nan", "%lf", &nan_val);
+    min_x = max_x = min_y = max_y = min_z = max_z = nan_val;


In #2681, the code was changed to use NAN:

/* init to nan in case no points are found */ min_x = max_x = min_y = max_y = min_z = max_z = NAN;

echoix · 2025-04-06T18:29:56Z

vector/v.cluster/main.c

 	    n = 0;
 	    sum = sumsq = 0;
-	    min = 1.0 / 0.0;
+		sscanf("inf", "%lf", &min);


In #2681, the code was changed to use INFINITY, but there's a note that it might not for MSVC (at that time)

min = INFINITY;

echoix · 2025-04-06T18:31:53Z

vector/v.cluster/main.c

 	    n = 0;
 	    sum = sumsq = 0;
-	    min = 1.0 / 0.0;
+		sscanf("inf", "%lf", &min);


In #2681, the code was changed to use INFINITY, but there's a note that it might not for MSVC (at that time)

min = INFINITY;

echoix · 2025-04-06T18:32:40Z

vector/v.distance/distance.c

+	double nan_val;
+	sscanf("-nan", "%lf", &nan_val);
+	box->E = box->W = box->N = box->S = box->T = box->B = nan_val;


In #2681, the code was changed to use NAN:

if (Points->n_points == 0) { box->E = box->W = box->N = box->S = box->T = box->B = NAN; return 0; }

echoix · 2025-04-06T18:33:36Z

vector/v.voronoi/skeleton.c

 	}

-	distmin = 1. / 0.; /* +inf */
+	sscanf("inf", "%lf", &distmin);


In #2681, the code was changed to use INFINITY, but there's a note that it might not for MSVC (at that time)

distmin = INFINITY;

echoix · 2025-04-06T20:47:37Z

Replaced by: #5511

rkanavath added 25 commits February 17, 2020 23:30

Add CMake support

98bda80

Avoid use of bare-exception

628e04b

use python3

2d3d0ba

check for GRASS_CONFIG_DIR to load rc and env.sh from it

6ea13bc

Add cmake configure input files

6de92e6

fix install commands

4c97b17

PROJ.4 -> PROJ

7aed313

fix ctypesgen

cbbb42e

fix build gui/icons

4a915f7

fix cmake deps of nviz, ogsf

4f75c29

MSVC: add unistd.h

4478942

MSVC: missing strings.h

a24d946

MSVC: missing dirent on MSVC

69d32cd

MSVC: win32 gettimeofday replacement from postgresql

2236aa6

MSVC: add __declspec attribute on windows

fb134e0

export static int initialized

d1caa3e

static int initialized is not working for MSVC and must export this with __declspec so that it appears in a DLL correctly. This change has been tested on Ubuntu and MSVC 2019 and is working as expected.

MSVC: ostream header is avaiable in GCC and MSVC

57a6ed1

missing include

5696858

MSVC: chmod is unix only

6357415

MSVC: fix struct complex

e0b7170

MSVC does not support VLAs

af03bf1

The MSVC compiler only supports C90, it does not support C99 and variable length arrays are a feature of C99.

MSVC: Fix pointer arithmetic

ceb1d12

MSVC: fix nan/inf issues on msvc and gcc

f76f205

rkanavath mentioned this pull request Feb 18, 2020

Msvc support 3 #356

Open

metzm mentioned this pull request Feb 24, 2020

fix g.list on msvc using pcre #358

Closed

rkanavath changed the title ~~[WIP] Msvc nan inf~~ Msvc nan inf Mar 2, 2020

neteler added enhancement New feature or request windows Microsoft Windows specific labels Dec 9, 2021

neteler added this to the 8.2.0 milestone Dec 9, 2021

wenzeslaus modified the milestones: 8.2.0, 8.4.0 Feb 27, 2022

wenzeslaus modified the milestones: 8.3.0, 8.4.0 Feb 10, 2023

wenzeslaus modified the milestones: 8.4.0, Future Apr 26, 2024

echoix reviewed Apr 6, 2025

View reviewed changes

echoix mentioned this pull request Apr 6, 2025

MSVC: fix nan/inf issues on msvc and gcc #5511

Open

echoix closed this Apr 6, 2025

Uh oh!

Msvc nan inf #355

Msvc nan inf #355

Uh oh!

Conversation

rkanavath commented Feb 18, 2020

Uh oh!

wenzeslaus commented Feb 19, 2025

Uh oh!

echoix left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

echoix commented Apr 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants