Porting 8.0 product_customer_code

[hurrinico]

I've made a fork of #38 and rebase it

[eLBati]

Please see travis

product_customer_code/product.py:27:1: F401 '_' imported but unused
product_customer_code/product_customer_code.py:27:1: F401 '_' imported but unused

[hurrinico]

@eLBati fixed

[eLBati]

@hurrinico please consider suggestions made since #38 (diff)

[eLBati]

Not imported python files should be removed

[pedrobaeza]

I think a better path is to use product_supplierinfo_for_customer module as base for the customer code instead of creating a new model.

[eLBati]

We are using product_customer_code in several 7.0 and 8.0 instances and I would prefer to keep the current structure, to avoid issues with the existing databases

[pedrobaeza]

OK, but we should merge both concepts in v9.

[andhit-r]

@hurrinico would you:

1. Adjust README.rst according to latest OCA guideline
2. Use simple header on every .py file

[mikevhe18]

I've made some changes to increase coverage/coveralls, then also adjustments to version 8 and OCA guidelines.

[coveralls]

Coverage increased (+9.7%) to 80.938% when pulling d2793fa on hurrinico:rebase_product_attribute into 6a5bc1a on OCA:8.0.

[eLBati]

@hurrinico @mikevhe18 please see failing checks

************* Module product_customer_code
product_customer_code/__init__.py:1: [W7908(missing-newline-extrafiles), ] views/product_product_view.xml Missing newline
************* Module product_customer_code.__openerp__
product_customer_code/__openerp__.py:5: [C8106(manifest-version-format), ] Wrong Version Format "1.0" in manifest file. Regex to match: "(\d+.\d+.\d+.\d+.\d+)"

[mikevhe18]

hello @hurrinico, i've fixed the code. Thanks in advance

[coveralls]

Coverage increased (+9.7%) to 80.938% when pulling 28eccbf on hurrinico:rebase_product_attribute into 6a5bc1a on OCA:8.0.

[andhit-r]

Tested functionality on runbot 👍

[mikevhe18]

👍

[andhit-r]

Hi @OCA/product-maintainers would you kindly review this PR? Many thanks

[mikevhe18]

Hello @pedrobaeza @eLBati, would you kindly review this PR again ?

[dcoopennet]

👍

[eLBati]

Please use figure like at https://raw.githubusercontent.com/OCA/maintainer-tools/master/template/module/README.rst

[eLBati]

A few comments then LGTM 👍

[hurrinico]

@eLBati i've made the requested fix

[bealdav]

tested LGTM for me 👍
off-topic Migration: in product.product view: 'Customer Code' tab name could replaced by 'Customer Infos' because other modules could extend custom informations (as name or any field)

[pedrobaeza]

Please check Travis status. Do we need to have a specific task for this?

[eLBati]

@pedrobaeza , @espo-tony is on the problem of duplicate key value violates unique constraint "product_template_uniq_prefix_code"

[espo-tony]

@pedrobaeza , @eLBati
Travis seems to raise an error while running a tes. More specifically, it returns a duplicate key value violates unique constraint "product_template_uniq_prefix_code" after invoking the copy method on the model product.product.

According to the tests and the analysis I performed, the issue doesn't look to depend on the module "product_customer_code". Instead, it looks like the duplication of a product.product record is not possible anymore because of a bug introduced by the modules 'product_code_builder' and 'product_code_builder_sequence'.

Please give a look to the PRs #181 , #182 for further informations on this bug and to review a possible solution to them (notice that solving those bugs, also the Travis errors remarked on this PR should be solved).

[eLBati]

For me this can be closed , as product_supplierinfo_for_customer is already available and overlapping with this.
See #236 (comment)

[hurrinico]

IMHO this can be closed