Skip to content

[REF] product_customer_code: Migrate module product_customer_code to new api#276

Closed
ysantiago wants to merge 1 commit intoOCA:8.0from
vauxoo-dev:8.0-migrate-product-customer-code-yennifer
Closed

[REF] product_customer_code: Migrate module product_customer_code to new api#276
ysantiago wants to merge 1 commit intoOCA:8.0from
vauxoo-dev:8.0-migrate-product-customer-code-yennifer

Conversation

@ysantiago
Copy link
Contributor

@ysantiago ysantiago commented Jun 23, 2017

No description provided.

@oca-clabot
Copy link

oca-clabot commented Jun 23, 2017

Hey @ysantiago, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@ysantiago ysantiago force-pushed the 8.0-migrate-product-customer-code-yennifer branch 3 times, most recently from 07a3dc8 to 1140556 Compare June 23, 2017 19:03
moylop260
moylop260 reviewed Jun 23, 2017
View reviewed changes
product_customer_code/__openerp__.py Outdated
"name": "Products Customer Code",
"version": "1.0",
"author": "Vauxoo,Odoo Community Association (OCA)",
"version": "8.0.0.0.1",
Copy link

@moylop260 moylop260 Jun 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 8.0.1.0.0

moylop260
moylop260 reviewed Jun 23, 2017
View reviewed changes
product_customer_code/README.rst Outdated

* Julio Serna Hernández <julio@vauxoo.com>
* Yennifer Santiago <yennifer@vauxoo.com>
* Moises Lopez <moylop260@vauxoo.com>
Copy link

@moylop260 moylop260 Jun 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moisés López

@ysantiago ysantiago force-pushed the 8.0-migrate-product-customer-code-yennifer branch from 1140556 to a35619c Compare June 23, 2017 21:04
@ysantiago ysantiago force-pushed the 8.0-migrate-product-customer-code-yennifer branch from a35619c to 817bcd7 Compare June 23, 2017 21:11
JulioSerna
JulioSerna approved these changes Jun 23, 2017
View reviewed changes
Copy link

@JulioSerna JulioSerna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

moylop260
moylop260 approved these changes Jun 23, 2017
View reviewed changes
Copy link

@moylop260 moylop260 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Red travis is unrelated since that stable branch has the same error result too

@moylop260
Copy link

moylop260 commented Jun 23, 2017

@pedrobaeza @max3903 Could you validate the CLA to merge this one?

@AaronHForgeFlow
Copy link
Contributor

AaronHForgeFlow commented Jun 26, 2017 •
edited
Loading

It seems that product_customer_code is overlapped by product_supplierinfo_for_customer. The last one is merged in v8 and there was a previous Pull Request for product_customer_code in v8 (#122) that was closed for the same reason. IMHO I agree to maintain product_supplierinfo_for_customer instead of product_customer_code

@moylop260
Copy link

moylop260 commented Jun 26, 2017

@aheficent You are right!
Thanks for reply

Note: We should add a note in the readme about a overlapping module.

@moylop260 moylop260 closed this Jun 26, 2017
@oca-clabot
Copy link

oca-clabot commented Jun 27, 2017

Hey @ysantiago,
We acknowledge that the following users have signed our Contributor License Agreement:

Appreciation of efforts,
OCA CLAbot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moylop260 moylop260 moylop260 approved these changes

+1 more reviewer

@JulioSerna JulioSerna JulioSerna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ysantiago @oca-clabot @moylop260 @AaronHForgeFlow @JulioSerna