Skip to content

[FIX] website_sale_require_legal: fix race condition in UI tour test #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kimkhoi3010 wants to merge 1 commit into
base: 16.0
Choose a base branch
from
+6 −6
Open

[FIX] website_sale_require_legal: fix race condition in UI tour test #1170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions website_sale_require_legal/static/tests/tours/tour.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,15 @@ odoo.define("website_sale_require_legal.tour", function (require) {
trigger: "div[name='o_checkbox_container'] input",
},
{
trigger: ".btn-primary:contains('Pay Now')",
trigger: '#payment_method label:contains("Dummy Provider")',
},
{
trigger: '#payment_method label:contains("Dummy Provider")',
trigger: 'button[name="o_payment_submit_button"]:not([disabled])',
},
{
trigger: 'button[name="o_payment_submit_button"]',
content: "Wait for payment to be processed and redirect",
trigger: "form.oe_product_cart",
timeout: 30000,
},
];

Expand Down
4 changes: 1 addition & 3 deletions website_sale_require_legal/tests/test_ui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@ def setUp(self):
# Create a dummy payment provider to ensure that the tour has at least one
# available to it.
arch = """
<form action="dummy" method="post">
<input type="hidden" name="view_id" t-att-value="viewid"/>
<input type="hidden" name="user_id" t-att-value="user_id.id"/>
<form action="/shop/payment/validate" method="get">
</form>
"""
redirect_form = self.env["ir.ui.view"].create(
Expand Down