[FIX] website_sale_require_legal: fix race condition in UI tour test

[Kimkhoi3010]

Context

• Fix a race condition in the UI tour test that caused intermittent failures when sale_loyalty is installed alongside website_sale_require_legal.
• The Odoo payment widget (web.assets_frontend_lazy) initializes asynchronously. The submit button starts as disabled="true" in the HTML template and is only enabled by the widget's _enableButton() after async initialization completes.
• The Tour Manager can become ready before the payment widget finishes initializing. When the tour clicked button[name="o_payment_submit_button"] while it was still disabled, no event handler fired, no AJAX was sent to /shop/payment/transaction, and the browser never navigated — causing the final form.oe_product_cart step to time out.
• The presence of sale_loyalty adds enough overhead during page load to make this timing window consistently reproducible.

Changes

• static/tests/tours/tour.js:
  • Add a final tour step waiting for form.oe_product_cart on the shop page, ensuring the AJAX call has completed before the tour ends.
• tests/test_ui.py:
  • Change the dummy provider's redirect form to action="/shop/payment/validate" so the browser navigates to /shop only after the AJAX response is received.

[pedrobaeza]

You can't use self.env["loyalty.program"] in a module that don't depend on the module adding that model, so you have to find another solution.

[Kimkhoi3010]

You can't use self.env["loyalty.program"] in a module that don't depend on the module adding that model, so you have to find another solution.

Hi @pedrobaeza, I have updated the PR. Thanks for your time.