[MIG][13.0] connector_magento by bizzappdev · Pull Request #317 · OCA/connector-magento

bizzappdev · 2021-03-09T07:29:11Z

No description provided.

* Add binding on sales orders * Ensure that we always have the Connector Manager group on the Connector tabs (most are done in the parent views of connector_ecommerce) * Fixed inheritance of the delivery.carrier view

* Use vcr.py to record the exchanges instead of a self-made recorder * Use new base Components test case classes * Separate export tests in 2 phases: trigger of the export which check that the jobs are delayed, and test the job itself in a second test

I removed it earlier, but it is required when we import products

… on the wrong one

* Rename it because it was shadowing another test * Compute in the location's context

The wizard is available on the backend.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: connector-magento-12.0/connector-magento-12.0-connector_magento Translate-URL: https://translation.odoo-community.org/projects/connector-magento-12-0/connector-magento-12-0-connector_magento/

- Rule paid to allow for order with nothing to pay (i.e. grand_total is zero) - Rule paid not to allow negative paid amount - Row totals are excl. discount amount

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: connector-magento-12.0/connector-magento-12.0-connector_magento Translate-URL: https://translation.odoo-community.org/projects/connector-magento-12-0/connector-magento-12-0-connector_magento/

paulius-sladkevicius · 2021-03-12T15:47:19Z

@bizzappdev great work! Looks Travis is failing because of a missing dependency base_technical_user. As I'm not 100% sure how Travis is taking it, but I suppose it would be enough to add server-tools to the oca_dependencies

connector_magento/wizards/magento_binding_backend_read.py

naglis · 2021-08-09T13:50:26Z

connector_magento/wizards/magento_binding_backend_read.py

+            _logger.info(
+                "No component registry for database %s. "
+                "Probably because the Odoo registry has not been built "
+                "yet." % (self.env.cr.dbname)


Suggested change

"yet." % (self.env.cr.dbname)

"yet.", self.env.cr.dbname

Please note that leaving the string formatting to the logger is better, since it will only format it if the logging level is enabled (avoids computation if not needed) and also it can have unintended consequences with other tools, e.g. Sentry will not group the events correctly if the log message is already formatted.

Sources: [1], [2], see also pylint W1202 rule.

victoralmau

Good job, just a few small changes (mostly to simplify super())

victoralmau · 2021-08-19T12:19:23Z

connector_magento/__manifest__.py

+
+{
+    "name": "Magento Connector",
+    "version": "13.0.0.0.0",


Suggested change

"version": "13.0.0.0.0",

"version": "13.0.1.0.0",

victoralmau · 2021-08-19T12:21:36Z

connector_magento/components/exporter.py

+    _usage = "record.exporter"
+
+    def __init__(self, working_context):
+        super(MagentoBaseExporter, self).__init__(working_context)


Suggested change

super(MagentoBaseExporter, self).__init__(working_context)

super().__init__(working_context)

victoralmau · 2021-08-19T12:21:53Z

connector_magento/components/exporter.py

+    _inherit = "magento.base.exporter"
+
+    def __init__(self, working_context):
+        super(MagentoExporter, self).__init__(working_context)


Suggested change

super(MagentoExporter, self).__init__(working_context)

super().__init__(working_context)

victoralmau · 2021-08-19T12:22:44Z

connector_magento/components/importer.py

+    _usage = "record.importer"
+
+    def __init__(self, work_context):
+        super(MagentoImporter, self).__init__(work_context)


Suggested change

super(MagentoImporter, self).__init__(work_context)

super().__init__(work_context)

victoralmau · 2021-08-19T12:23:21Z

connector_magento/components/line_builder.py

+    _usage = "order.line.builder.magento.store_credit"
+
+    def __init__(self, work_context):
+        super(StoreCreditLineBuilder, self).__init__(work_context)


Suggested change

super(StoreCreditLineBuilder, self).__init__(work_context)

super().__init__(work_context)

victoralmau · 2021-08-19T12:44:51Z

connector_magento/tests/test_import_partner.py

+
+class TestImportPartner(MagentoSyncTestCase):
+    def setUp(self):
+        super(TestImportPartner, self).setUp()


Suggested change

super(TestImportPartner, self).setUp()

super().setUp()

victoralmau · 2021-08-19T12:45:08Z

connector_magento/tests/test_import_product.py

+
+class TestImportProduct(MagentoSyncTestCase):
+    def setUp(self):
+        super(TestImportProduct, self).setUp()


Suggested change

super(TestImportProduct, self).setUp()

super().setUp()

victoralmau · 2021-08-19T12:45:26Z

connector_magento/tests/test_import_product_image.py

+    """ Test the imports of the image of the products. """
+
+    def setUp(self):
+        super(TestImportProductImage, self).setUp()


Suggested change

super(TestImportProductImage, self).setUp()

super().setUp()

victoralmau · 2021-08-19T12:45:41Z

connector_magento/tests/test_related_action.py

+    """ Test related actions on stored jobs """
+
+    def setUp(self):
+        super(TestRelatedActionStorage, self).setUp()


Suggested change

super(TestRelatedActionStorage, self).setUp()

super().setUp()

victoralmau · 2021-08-19T12:45:58Z

connector_magento/tests/test_sale_order.py

+
+class TestSaleOrder(MagentoSyncTestCase):
+    def setUp(self):
+        super(TestSaleOrder, self).setUp()


Suggested change

super(TestSaleOrder, self).setUp()

super().setUp()

elvise · 2022-05-24T19:26:06Z

@sbidoul can you help me with runboat ? 🙂

sbidoul · 2022-05-25T10:42:39Z

A rebase or push will create a build.

elvise · 2022-05-25T12:37:23Z

@bizzappdev can you rebase ?

bizzappdev · 2022-05-25T12:54:21Z

@bizzappdev can you rebase ?

I just did 2 hours ago. and right now Already is up to date.

paulius-sladkevicius · 2022-10-12T09:00:11Z

Hello, any possibility to merge it to 13.0 I see it stuck a bit :-)

Guewen Baconnier and others added 30 commits March 9, 2021 10:47

Rename magentoerpconnect to connector_magento

f708cec

Restructure files, split large python files

4235883

Fix views

d0e37e4

* Add binding on sales orders * Ensure that we always have the Connector Manager group on the Connector tabs (most are done in the parent views of connector_ecommerce) * Fixed inheritance of the delivery.carrier view

Collection.work_on is now a context manager

a7c20c8

Add a base listener and use it in partner export

ae453b7

Update documentation

5a4f515

Various fixes

2df1daa

Add dependency on product_multi_category

3c5c497

I removed it earlier, but it is required when we import products

Manage multi-company backend

0cb6172

Fix Pylint warnings

ff6e381

Remove deprecated select for index creation

98f6ba2

[FIX] pass http credentials to backedn component if required

aa67342

[FIX] change user on backend otherwise import sale order will be done…

d799320

… on the wrong one

[CHG]review product aggregation by backend to improve performance

f9c7a4b

Apply fiscal position

1834a94

Remove related_action from import_batch

860ddb6

Allow service type product based on 'giftcard' type in Magento.

0e561c4

Change return value matching with the comment

441d14e

Fix failing test

da7bcfd

* Rename it because it was shadowing another test * Compute in the location's context

Listen for new on_picking_dropship_done event.

f0ba4be

Add new wizard to read data from magento

eecbd22

The wizard is available on the backend.

OCA Transbot updated translations from Transifex

bdda141

[MIG] connector_magento to v11

8a9ad05

[MIG] connector_magento to v11

e396491

[MIG] connector_magento: Migration to 12.0

edc334d

[ADD] Magento2 compatibility

553f350

[UPD] Update connector_magento.pot

5115041

[IMP] Set a pricelist based on the currency of the order

483d4e7

OCA-git-bot and others added 9 commits March 9, 2021 10:47

connector_magento 12.0.1.1.1

72b7d6e

[UPD] Update connector_magento.pot

133a317

connector_magento 12.0.1.1.2

408485b

[FIX] Incorrect discount handling

06bef57

- Rule paid to allow for order with nothing to pay (i.e. grand_total is zero) - Rule paid not to allow negative paid amount - Row totals are excl. discount amount

[UPD] Update connector_magento.pot

79e750c

connector_magento 12.0.1.1.3

b601287

connector_magento 12.0.1.1.4

ab59fab

bizzappdev mentioned this pull request Mar 9, 2021

[WIP][DRAFT][MIG][13.0] connector magento #312

Closed

bizzappdev force-pushed the 13.0-mig-connector_magento-format-patch branch 2 times, most recently from 0c2384d to 1f1f320 Compare March 9, 2021 08:37

naglis reviewed Aug 9, 2021

View reviewed changes

connector_magento/wizards/magento_binding_backend_read.py Outdated Show resolved Hide resolved

bizzappdev changed the title ~~[MIG][13.0] connector Magento~~ [MIG][13.0] connector_magento Aug 9, 2021

naglis reviewed Aug 9, 2021

View reviewed changes

victoralmau suggested changes Aug 19, 2021

View reviewed changes

pedrobaeza added this to the 13.0 milestone Aug 19, 2021

victoralmau mentioned this pull request Aug 25, 2021

[13.0][MIG] connector_magento: Migration to 13.0 #327

Closed

1 task

bizzappdev added 2 commits May 25, 2022 16:26

[IMP] : black, isort, prettier

19829a3

[MIG] connector_magento: Migration to 13.0

9a735fe

bizzappdev force-pushed the 13.0-mig-connector_magento-format-patch branch from 70bb8da to 885b62c Compare May 25, 2022 10:56

[FIX] mapping

747cde7

bizzappdev force-pushed the 13.0-mig-connector_magento-format-patch branch from 885b62c to 747cde7 Compare May 25, 2022 11:00

dreispt mentioned this pull request Apr 27, 2024

[MIG][13.0] connector_magento: Migration to 13.0 #337

Open

	super(MagentoBaseExporter, self).__init__(working_context)
	super().__init__(working_context)

	super(MagentoExporter, self).__init__(working_context)
	super().__init__(working_context)

	super(MagentoImporter, self).__init__(work_context)
	super().__init__(work_context)

	super(StoreCreditLineBuilder, self).__init__(work_context)
	super().__init__(work_context)

	super(TestRelatedActionStorage, self).setUp()
	super().setUp()

Uh oh!

Conversation

bizzappdev commented Mar 9, 2021

Uh oh!

paulius-sladkevicius commented Mar 12, 2021

Uh oh!

Uh oh!

naglis Aug 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

victoralmau left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elvise commented May 24, 2022

Uh oh!

sbidoul commented May 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elvise commented May 25, 2022

Uh oh!

bizzappdev commented May 25, 2022

Uh oh!

paulius-sladkevicius commented Oct 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

naglis Aug 9, 2021 •

edited

Loading

sbidoul commented May 25, 2022 •

edited

Loading