[13.0][MIG] connector_magento: Migration to 13.0 by victoralmau · Pull Request #327 · OCA/connector-magento

victoralmau · 2021-08-25T07:11:18Z

Superseed: #317

Migration to 13.0

New features:

Add export_magento_qty button to force recompute qty in products.
Add import sale order wizard by number in backend.
Add transaction related to order.
Add test to check import orders in different currencies.

Locked by:

connector_ecommerce [13.0][MIG] connector_ecommerce: Migration to 13.0 connector-ecommerce#62

Please @pedrobaeza and @joao-p-marques can you review it?

@Tecnativa TT30700

* Add binding on sales orders * Ensure that we always have the Connector Manager group on the Connector tabs (most are done in the parent views of connector_ecommerce) * Fixed inheritance of the delivery.carrier view

* Use vcr.py to record the exchanges instead of a self-made recorder * Use new base Components test case classes * Separate export tests in 2 phases: trigger of the export which check that the jobs are delayed, and test the job itself in a second test

I removed it earlier, but it is required when we import products

… on the wrong one

* Rename it because it was shadowing another test * Compute in the location's context

The wizard is available on the backend.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: connector-magento-12.0/connector-magento-12.0-connector_magento Translate-URL: https://translation.odoo-community.org/projects/connector-magento-12-0/connector-magento-12-0-connector_magento/

…to amount_percent

…pute qty in products

…ckend

… paid is added (only if the import of paid orders is used in the payment method and a payment acquirer is defined). If the amount paid is equal to the order total, the transaction will be marked as completed and the order will be auto-confirmed.

… currencies.

victoralmau · 2021-09-23T06:34:58Z

Now connector_ecommerce addon is already merged.
I have relaunched Travis to verify that the tests work correctly.
If you confirm that everything is OK, it could already be merged, right?

joao-p-marques

Code review

joao-p-marques · 2021-10-05T10:13:35Z

connector_magento/components/backend_adapter.py

+
+    def _call(self, method, arguments=None, http_method=None, storeview=None):
+        try:
+            magento_api = getattr(self.work, "magento_api")  # noqa: B009


Don's just silence the linter in this case, as it is easy to fix:

Suggested change

magento_api = getattr(self.work, "magento_api") # noqa: B009

magento_api = self.work["magento_api"]

joao-p-marques · 2021-10-05T10:14:31Z

connector_magento/components/backend_adapter.py

+        if not url:
+            raise ValueError("No admin URL configured on the backend.")
+        if hasattr(self.model, "_get_admin_path"):
+            admin_func = getattr(self.model, "_get_admin_path")  # noqa: B009


Same here as above:

Suggested change

admin_func = getattr(self.model, "_get_admin_path") # noqa: B009

admin_func = self.model["_get_admin_path"]

joao-p-marques · 2021-10-05T10:28:55Z

connector_magento/models/account_invoice/common.py

+                    create_invoice = magento_store.create_invoice_on
+
+                if (
+                    create_invoice == "paid"


I see you compare create_invoice with either "paid" or "open" but, a few lines above, it is asigned the value of create_invoice_on, which would suggest a different sort of value... Can you confirm it is being handled properly and explain a bit more why this change?

joao-p-marques · 2021-10-05T10:39:41Z

connector_magento/models/partner/importer.py

+    direct = [
+        ("email", "email"),
+        ("dob", "birthday"),
+        # (normalize_datetime('created_at'), 'created_at'),


Suggested change

# (normalize_datetime('created_at'), 'created_at'),

joao-p-marques · 2021-10-05T10:42:13Z

connector_magento/models/partner/importer.py

+        region = record.get("region")
+        if isinstance(region, dict):
+            region = region.get("region")


Just to confirm, this would mean accessing record["region"]["region"]. Is that the expected structure?

joao-p-marques · 2021-10-05T11:21:22Z

connector_magento/tests/test_import_product_image.py

+                    },  # noqa
+                    {
+                        "exclude": "0",
+                        # noqa


Suggested change

# noqa

joao-p-marques · 2021-10-05T11:21:35Z

connector_magento/tests/test_import_product_image.py

+                        "types": ["thumbnail"],
+                        "url": "http://localhost:9100/media/catalog/product/i/n/"
+                        "ink-eater-krylon-bombear-destroyed-tee-2.jpg",
+                    },  # noqa


Suggested change

}, # noqa

},

joao-p-marques · 2021-10-05T11:21:43Z

connector_magento/tests/test_import_product_image.py

+                        "types": ["small_image"],
+                        "url": "http://localhost:9100/media/catalog/product/i/n/"
+                        "ink-eater-krylon-bombear-destroyed-tee-1.jpg",
+                    },  # noqa


Suggested change

}, # noqa

},

joao-p-marques · 2021-10-05T11:21:47Z

connector_magento/tests/test_import_product_image.py

+                        "types": [],
+                        "url": "http://localhost:9100/media/catalog/product/m/a/"
+                        "connector_magento_1.png",
+                    },  # noqa


Suggested change

}, # noqa

},

joao-p-marques · 2021-10-05T11:22:31Z

connector_magento/tests/test_sale_order.py

+        )
+
+    def test_import_sale_order_paid(self):
+        payment_checkmo = self.env["account.payment.mode"].search(


Same doubts here as above

pedrobaeza · 2021-10-05T11:26:10Z

For now, we are holding this pull request, as we are going to speed up the transition to Odoo e-commerce, and not needing this, so o more changes should be applied, although we keep it opened as reference for anyone wanting it.

paulius-sladkevicius · 2021-11-25T11:05:24Z

connector_magento/models/sale_order/importer.py

+    def tax_id(self, record):
+        tax_percent = float(record["tax_percent"] or 0)
+        if tax_percent > 0:
+            tax_record = self.env["account.tax"].search(
+                [
+                    ("type_tax_use", "=", "sale"),
+                    ("amount_type", "=", "percent"),
+                    ("amount", "=", tax_percent),
+                ]
+            )
+            if not tax_record:
+                raise FailedJobError("Missing tax for amount: %s" % tax_percent)
+            return {"tax_id": [(4, tax_record.id)]}


We faced an issue with tax mapping as previous version a tax was set from the product settings and then a fiscal position was applied that handles correctly final taxes.

This code tries to take a tax with the same percentage even if the tax on a product is different. Extra, in case there are more than one tax (for different countries) with the same percentage it will fail as code expect to provide 1 tax, not all of them.

My suggestion is to remove this mapping and leave Odoo default behaviour when a tax is set on the SO line.

john-herholz-dt · 2022-05-10T08:32:10Z

Hello,

I was also working on getting the connector-magento 12.0 branch running for 15.0 and saw this pull request.
I have not yet contributed to OCA modules, but would like to do so.

At the moment I don't know where to start and who is responsible to check PRs.
I saw a lot of migrations are hanging for months because of missing migrations of other depending modules.

Long story short, who can give me a kickstart on contributing to OCA and how to communicate?

hailangvn · 2022-05-15T11:29:52Z

Good day @john-herholz-dt, thanks for your initiation. Hope below steps can help.

First document to read is How To section to understand about how to start.
Then in case you still want to migrate the module, you should put a comment in tracking of migrations to 15.0 like this comment but with WIP instead of PR number. That is to inform other persons to not spend time on same work.
While doing migration, the rest of the guide should be read and followed.
After creating PR, you then update the comment with the link to the PR. The early you put the link, the better, not wait until when your migration is done. That will help you receive suggestions.

elvise · 2022-05-27T14:52:21Z

hi @victoralmau do you have any plan to finish this task ?

pedrobaeza · 2022-05-27T15:02:11Z

We are not finally using it, as we switched to Odoo e-commerce, but feel free to take it from this point that is mostly OK.

Guewen Baconnier and others added 30 commits March 9, 2021 10:47

Rename magentoerpconnect to connector_magento

f708cec

Restructure files, split large python files

4235883

Fix views

d0e37e4

* Add binding on sales orders * Ensure that we always have the Connector Manager group on the Connector tabs (most are done in the parent views of connector_ecommerce) * Fixed inheritance of the delivery.carrier view

Collection.work_on is now a context manager

a7c20c8

Add a base listener and use it in partner export

ae453b7

Update documentation

5a4f515

Various fixes

2df1daa

Add dependency on product_multi_category

3c5c497

I removed it earlier, but it is required when we import products

Manage multi-company backend

0cb6172

Fix Pylint warnings

ff6e381

Remove deprecated select for index creation

98f6ba2

[FIX] pass http credentials to backedn component if required

aa67342

[FIX] change user on backend otherwise import sale order will be done…

d799320

… on the wrong one

[CHG]review product aggregation by backend to improve performance

f9c7a4b

Apply fiscal position

1834a94

Remove related_action from import_batch

860ddb6

Allow service type product based on 'giftcard' type in Magento.

0e561c4

Change return value matching with the comment

441d14e

Fix failing test

da7bcfd

* Rename it because it was shadowing another test * Compute in the location's context

Listen for new on_picking_dropship_done event.

f0ba4be

Add new wizard to read data from magento

eecbd22

The wizard is available on the backend.

OCA Transbot updated translations from Transifex

bdda141

[MIG] connector_magento to v11

8a9ad05

[MIG] connector_magento to v11

e396491

[MIG] connector_magento: Migration to 12.0

edc334d

[ADD] Magento2 compatibility

553f350

[UPD] Update connector_magento.pot

5115041

[IMP] Set a pricelist based on the currency of the order

483d4e7

victoralmau force-pushed the 13.0-mig-connector_magento branch 3 times, most recently from 9ba05ae to 552364f Compare August 30, 2021 14:08

bizzappdev and others added 3 commits August 31, 2021 12:32

[ADD]OCA dependencies

cfc65d7

[FIX]added db name in logger

448bd60

[MIG] connector_magento: Migration to 13.0

1bccbdb

victoralmau force-pushed the 13.0-mig-connector_magento branch 4 times, most recently from 76ae249 to fca6baa Compare September 3, 2021 15:13

victoralmau marked this pull request as ready for review September 3, 2021 15:25

victoralmau force-pushed the 13.0-mig-connector_magento branch 2 times, most recently from fabd1e7 to b81f49a Compare September 7, 2021 07:04

victoralmau added 6 commits September 23, 2021 08:18

[IMP] connector_magento: Add requirements.txt

c0a2d12

[FIX] connector_magento: Set correct tax_id in order lines according …

1700a9d

…to amount_percent

[IMP] connector_magento: Add export_magento_qty button to force recom…

89bc27e

…pute qty in products

[IMP] connector_magento: Add import sale order wizard by number in ba…

c167368

…ckend

[IMP] connector_magento: Add test to check import orders in different…

9910c63

… currencies.

victoralmau force-pushed the 13.0-mig-connector_magento branch from b81f49a to 9910c63 Compare September 23, 2021 06:19

pedrobaeza added this to the 13.0 milestone Sep 23, 2021

joao-p-marques suggested changes Oct 5, 2021

View reviewed changes

paulius-sladkevicius reviewed Nov 25, 2021

View reviewed changes

pedrobaeza closed this May 27, 2022

	magento_api = getattr(self.work, "magento_api") # noqa: B009
	magento_api = self.work["magento_api"]

	admin_func = getattr(self.model, "_get_admin_path") # noqa: B009
	admin_func = self.model["_get_admin_path"]

Uh oh!

Conversation

victoralmau commented Aug 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

victoralmau commented Sep 23, 2021

Uh oh!

joao-p-marques left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Oct 5, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

john-herholz-dt commented May 10, 2022

Uh oh!

hailangvn commented May 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elvise commented May 27, 2022

Uh oh!

pedrobaeza commented May 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

victoralmau commented Aug 25, 2021 •

edited

Loading

hailangvn commented May 15, 2022 •

edited

Loading

pedrobaeza commented May 27, 2022 •

edited

Loading