Skip to content

Fix sale order onchange failure on False value on M2o #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guewen wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

Fix sale order onchange failure on False value on M2o #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion connector_ecommerce/components/sale_order_onchange.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,16 @@ def get_new_values(self, record, on_change_result, model=None):
if model:
column = self.env[model]._fields[fieldname]
if column.type == "many2one":
value = value[0] # many2one are tuple (id, name)
if value:
assert (
isinstance(value, (tuple, list)) and len(value) == 2
), (
"onchange() on model %s "
"should return a tuple with 2 elements "
"(id, name) as value for many2one field %s"
% (model, fieldname)
)
value = value[0]
new_values[fieldname] = value
return new_values

Expand Down