Fix sale order onchange failure on False value on M2o#77
Open
Fix sale order onchange failure on False value on M2o#77
Conversation
StephaneMangin
approved these changes
May 30, 2023
john-herholz-dt
left a comment
john-herholz-dt
left a comment
There was a problem hiding this comment.
I just ran across this today when migrating the onchange_helper for 17.0.
This here is a cool addition, might need a change for 17.0 as well, because I got a dict instead of tuple now.
john-herholz-dt
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an onchange returns False for a m2o field, the sale order onchange component will fail because it tries to get the first item of the tuple (id, name). We should just keep the False value.